binaryninja-free: Fix libxml2 breakage#420487
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jul 5, 2025
Merged
Conversation
nixpkgs-ci
bot
added
12.first-time contribution
acid-bong
suggested changes
Jun 27, 2025
Contributor
acid-bong
left a comment
acid-bong
left a comment
There was a problem hiding this comment.
Please, read the docs linked in the last checklist item on how to manage and name commits
13 tasks
N0tExisting
changed the title
binaryninja-freebinaryninja-free: Fix libxml2 breakage
acid-bong
approved these changes
Jul 3, 2025
nixpkgs-ci
bot
added
the
12.approvals: 1
Aleksanaa
changed the title
binaryninja-free: Fix libxml2 breakage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #418655
See: #396195
@spencerpogo
Things done
Added
preFixupfrom #396195 (comment)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.