(mostly) Pass nixpkgs release checks on RISC-V#420442
Merged
wegank merged 11 commits intoNixOS:masterfrom Jul 12, 2025
Merged
Conversation
wegank
approved these changes
Jul 12, 2025
13 tasks
This was referenced Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from box86, rocm, and swift, these packages only support a limited set of architectures or systems, and dereference a small attrset with the architecture name or the like. This works fine if you are only targeting x86_64 or amd64, however it doesn’t work on riscv. I have added
throwfallbacks to the ones that cause failures in nixpkgs’ release checks.rocm and swift use LLVM as the code generator, which does support RISC-V but I have not verified if they support RISC-V so i kept them disabled.
This doesn’t fully fix the errors, as many derivations require the
archproperty to be set in the parsed CPU info. It is unclear to me whether this is a bug in lib/systems/parse.nix or whether that property is just deprecatedThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.