Skip to content

(mostly) Pass nixpkgs release checks on RISC-V#420442

Merged
wegank merged 11 commits intoNixOS:masterfrom
DarkKirb:riscv-qa
Jul 12, 2025
Merged

(mostly) Pass nixpkgs release checks on RISC-V#420442
wegank merged 11 commits intoNixOS:masterfrom
DarkKirb:riscv-qa

Conversation

@DarkKirb
Copy link
Contributor

@DarkKirb DarkKirb commented Jun 27, 2025

Aside from box86, rocm, and swift, these packages only support a limited set of architectures or systems, and dereference a small attrset with the architecture name or the like. This works fine if you are only targeting x86_64 or amd64, however it doesn’t work on riscv. I have added throw fallbacks to the ones that cause failures in nixpkgs’ release checks.

rocm and swift use LLVM as the code generator, which does support RISC-V but I have not verified if they support RISC-V so i kept them disabled.

This doesn’t fully fix the errors, as many derivations require the arch property to be set in the parsed CPU info. It is unclear to me whether this is a bug in lib/systems/parse.nix or whether that property is just deprecated

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@DarkKirb DarkKirb changed the title Pass nixpkgs release checks on RISC-V (mostly) Pass nixpkgs release checks on RISC-V Jun 27, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. labels Jun 27, 2025
@0x4A6F 0x4A6F added the 6.topic: riscv64 RISC-V is an open standard instruction set architecture label Jun 27, 2025
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Jul 4, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 12, 2025
@wegank wegank merged commit 12cb0d4 into NixOS:master Jul 12, 2025
24 checks passed
@DarkKirb DarkKirb deleted the riscv-qa branch September 12, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 6.topic: riscv64 RISC-V is an open standard instruction set architecture 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants