Merged
Conversation
libcap_ng: modernize
Using github sources simplifies usage of update script. It is also preferrable, as it gives less opportunity for ingenuine preconfigured artifacts to be included in the release tarball. Checked using diffoscope: The output is identical to what the build using `fetchurl` yields, apart from the `libtool` version string in `$out/lib/libdrop_ambient.la` and nix store hashes.
This was referenced Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg-configpassthru testerchangelogto metameta.maintainersfinalAttrspatternstrictDeps = trueparallelBuilding = truedoCheck = trueChecked using diffoscope: The output is basically unchanged apart from one libtool version string, and a couple nix store hashes.
Things done
x86_64-darwinaarch64-darwinnix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.