Skip to content

libcap_ng: modernize, adopt#420001

Merged
K900 merged 6 commits intoNixOS:stagingfrom
LordGrimmauld:libcap_ng-adopt
Jul 2, 2025
Merged

libcap_ng: modernize, adopt#420001
K900 merged 6 commits intoNixOS:stagingfrom
LordGrimmauld:libcap_ng-adopt

Conversation

@LordGrimmauld
Copy link
Contributor

@LordGrimmauld LordGrimmauld commented Jun 25, 2025

  • add update script
  • build from github sources (simplifies update script)
  • pkg-config passthru tester
  • add changelog to meta
  • add pkg-config modules to meta
  • add grimmauld to meta.maintainers
  • use finalAttrs pattern
  • strictDeps = true
  • parallelBuilding = true
  • doCheck = true

Checked using diffoscope: The output is basically unchanged apart from one libtool version string, and a couple nix store hashes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • aarch64-linux (cross)
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

libcap_ng: modernize
Using github sources simplifies usage of update script.
It is also preferrable, as it gives less opportunity
for ingenuine preconfigured artifacts to be included
in the release tarball.

Checked using diffoscope: The output is identical to
what the build using `fetchurl` yields, apart from
the `libtool` version string in `$out/lib/libdrop_ambient.la`
and nix store hashes.
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 25, 2025
@LordGrimmauld LordGrimmauld requested a review from K900 July 2, 2025 09:45
@K900 K900 merged commit 3ca8806 into NixOS:staging Jul 2, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants