Skip to content

haskellPackages.haskore: fixed broken package (doJailbreak, dontCheck)#419877

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
lelambda:haskell-updates
Jun 29, 2025
Merged

haskellPackages.haskore: fixed broken package (doJailbreak, dontCheck)#419877
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
lelambda:haskell-updates

Conversation

@lelambda
Copy link
Contributor

@lelambda lelambda commented Jun 25, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Jun 25, 2025
wolfgangwalther
wolfgangwalther reviewed Jun 25, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use haskellPackages.haskore: as prefix for both commit and PR title. This will make sure that OfBorg will build this automatically in CI.

@lelambda
Copy link
Contributor Author

lelambda commented Jun 25, 2025

Thank you for the review.
Unfortunately, I'm quite new to GitHub, so I don't know the ropes yet:
Am I supposed to fix my mistakes and create a new pull request or is there a possibility to 'add' to this one?

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jun 25, 2025

Am I supposed to fix my mistakes and create a new pull request or is there a possibility to 'add' to this one?

Keep this pull request. You will now have to git rebase your branch and make the changes accordingly. Since you only have a single commit, you can just make the changes and then git commit --amend them to the existing commit. Then you'll need to force push the existing branch.

@lelambda lelambda changed the title haskell-haskore: fixed broken package (doJailbreak, dontCheck) haskellPackages.haskore: fixed broken package (doJailbreak, dontCheck) Jun 25, 2025
@lelambda lelambda requested a review from wolfgangwalther June 25, 2025 14:11
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 25, 2025
wolfgangwalther
wolfgangwalther reviewed Jun 25, 2025
View reviewed changes
maralorn
maralorn reviewed Jun 25, 2025
View reviewed changes
wolfgangwalther
wolfgangwalther approved these changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 419877
Commit: a69e840147fc4a7d20574335f9f597fc0787e17b

x86_64-linux

✅ 2 packages built:
  • haskellPackages.haskore
  • haskellPackages.haskore.doc

aarch64-linux

✅ 2 packages built:
  • haskellPackages.haskore
  • haskellPackages.haskore.doc

x86_64-darwin

✅ 2 packages built:
  • haskellPackages.haskore
  • haskellPackages.haskore.doc

aarch64-darwin

✅ 2 packages built:
  • haskellPackages.haskore
  • haskellPackages.haskore.doc

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
@lelambda lelambda requested a review from maralorn June 25, 2025 15:03
maralorn
maralorn approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@maralorn maralorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Can you quickly squash before the merge?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 25, 2025
sternenseemann
sternenseemann reviewed Jun 28, 2025
View reviewed changes
@maralorn
Copy link
Member

maralorn commented Jun 29, 2025

At this point this is maybe one of our best commented overrides. 😆

Thank you for your work.

@maralorn maralorn merged commit 52a883f into NixOS:haskell-updates Jun 29, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann sternenseemann left review comments

@maralorn maralorn maralorn approved these changes

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lelambda @wolfgangwalther @maralorn @sternenseemann