plover: unbork and move to by-name#419593
Open
Pandapip1 wants to merge 13 commits intoNixOS:masterfrom
Open
Conversation
nixpkgs-ci
bot
added
the
6.topic: python
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Pandapip1
force-pushed
the
plover-revamp
branch
2 times, most recently
from
12969b4 to
1a5c201
Compare
13 tasks
eclairevoyant
suggested changes
Jun 25, 2025
Member
Author
|
Bump! |
Pandapip1
requested review from
KoviRobi and
eclairevoyant
and removed request for
eclairevoyant
Member
Author
|
For some reason I can't request a review from @Twey, so here's a CC |
Member
Author
1 task
Member
Author
|
Actually never mind, this can't be backported because it renames the package. I guess I could reorder the commits? Seems a bit odd but is probably more sensible anyway. |
Member
Author
|
Okay, most of the changes can now be backported. It'll still be a manual backport though since the last two commits aren't backportable. |
Member
Author
|
Finally, I don't know why git really didn't want me to do that force-push (it kept giving me an 'up-to-date', must be some GitHub funkiness) |
Member
Author
|
Found a way to split up the commits even further so it's a rename, then a move to by-name. |
Pandapip1
force-pushed
the
plover-revamp
branch
from
fe8be80 to
94be37a
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Pandapip1
force-pushed
the
plover-revamp
branch
2 times, most recently
from
f837009 to
99accf6
Compare
Okay I will look into plover-flake thank you! |
nixpkgs-ci
bot
added
the
2.status: merge conflict
Pandapip1
force-pushed
the
plover-revamp
branch
from
99accf6 to
8a6898f
Compare
Member
Author
|
Resolved merge conflict. Would love to get this merged! |
nixpkgs-ci
bot
removed
the
2.status: merge conflict
Contributor
|
ProxyVT
approved these changes
Jan 15, 2026
Contributor
ProxyVT
left a comment
ProxyVT
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
nixpkgs-ci
bot
added
the
12.approvals: 1
nixpkgs-ci
bot
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #419420
Fixes #141797
Makes progress on #180841
Supersedes #426075
(sort of) Supersedes #119702
(sort of) Supersedes #110658
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @natsukium @Twey @KoviRobi
Add a 👍 reaction to pull requests you find important.