Skip to content

libetonyek: fix cross-compilation#419401

Merged
7c6f434c merged 1 commit intoNixOS:masterfrom
synalice-forks:libetonyek-fix-cross-comp
Jun 25, 2025
Merged

libetonyek: fix cross-compilation#419401
7c6f434c merged 1 commit intoNixOS:masterfrom
synalice-forks:libetonyek-fix-cross-comp

Conversation

@synalice
Copy link
Contributor

Closes #419359.

Fix broken cross-compilation.

What's been tested:

nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'
nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { crossSystem = { config = "aarch64-unknown-linux-gnu"; }; }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'
nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { crossSystem = { config = "riscv64-linux"; }; }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

What's been tested:

```
nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'
```
```
nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { crossSystem = { config = "aarch64-unknown-linux-gnu"; }; }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'
```
```
nix-build -I nixpkgs=channel:nixos-unstable -E 'let pkgs = import <nixpkgs> { crossSystem = { config = "riscv64-linux"; }; }; in pkgs.callPackage ./pkgs/by-name/li/libetonyek/package.nix { }'
```
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jun 23, 2025
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Jun 23, 2025
Copy link
Member

@SFrijters SFrijters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes nix-build -A pkgsCross.aarch64-multiplatform.libetonyek for me.

Consider adding strictDeps = true; to prevent regressions.

@SFrijters SFrijters requested a review from 7c6f434c June 25, 2025 21:10
@7c6f434c 7c6f434c merged commit 3f204b2 into NixOS:master Jun 25, 2025
27 of 28 checks passed
@synalice synalice deleted the libetonyek-fix-cross-comp branch June 28, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: libetonyek (cross-compilation)

3 participants