jetbrains: 2025.1.1 -> 2025.1.5#419026
Conversation
|
This doesn't build for me - nor does the pkgs.jetbrains.rider.override {
libxml2 = pkgs.runCommand "libxml2.so.2" { } ''
install -Dm555 \
${pkgs.libxml2.out}/lib/libxml2.so \
$out/lib/libxml2.so.2
'';
};Would this be worth upstreaming while you're at it, or should it be a separate PR in that case? I'm on aarch64 (Apple Silicon) for what its worth but the libxml issue doesn't seem architecture dependent. |
|
|
Validated idea-ultimate with a multi module project with Kotlin, Python and Typescript modules. |
|
|
Looks like on aarch64-linux, rider & clion need On aarch64-darwin, the failure was a local failure (No space left on device) caused by trying to build too much stuff in a github actions runner, so it is possible the build would've succeeded if there was more disk space. |
|
Probably better to use patchelf instead like some existing usages? The following has been working for me on aarch64-linux: jetbrains-clion = prev.jetbrains.clion.overrideAttrs (old: {
postFixup = ''
${old.postFixup}
patchelf --replace-needed libxml2.so.2 libxml2.so $out/clion/bin/lldb/linux/*/lib/liblldb.so
'';
});
jetbrains-rust-rover = prev.jetbrains.rust-rover.overrideAttrs (old: {
postFixup = ''
${old.postFixup}
patchelf --replace-needed libxml2.so.2 libxml2.so $out/rust-rover/bin/lldb/linux/*/lib/liblldb.so
'';
}); |
|
@sdht0 thanks for the tip. I was able to easily add another |
|
|
Note for future me and comitters: |
|
As I understood it the solution in this PR has some issue with JCEF, but the other PR (#425529) has other issues. I see there is discussion going on and comparing it with the solution in this PR already. There is also #426285 that is also trying to fix this issue. @ners Could you also have a look at those PRs and compare it with your solution and maybe give your opinions as well? In any case I think all fixes related to jetbrains-jdk should go there first and that be merged first, then we continue here IMO. I'm unfortunately not at all experienced with Java or really understand the changes that broke the jetbrains-jdk, so I can't really give a good opinion here myself on what is the best way to deal with these issues. As for the discontinued IDEs, I've made a new issue as a reminder (#426427), if somebody has time feel free to open a PR, otherwise I'll do it soon ™️ |
|
|
No idea if this helps, but I've been using this for a week or so now and it seems perfectly stable (aarch64-darwin). |
|
Just a heads up that new versions of IDEs are out (Ultimate 2025.1.4.1) so it'd be great to re-run the update script before this merges. |
|
theCapypara
left a comment
There was a problem hiding this comment.
I'm getting the same build failures unfortunately.
jetbrains.clion: 2025.1.2 -> 2025.1.4 jetbrains.dataspell: 2025.1.1 -> 2025.1.2.1 jetbrains.goland: 2025.1.2 -> 2025.1.4 jetbrains.idea-community: 2025.1.2 -> 2025.1.4.1 jetbrains.idea-ultimate: 2025.1.2 -> 2025.1.4.1 jetbrains.phpstorm: 2025.1.2 -> 2025.1.4.1 jetbrains.pycharm-community: 2025.1.2 -> 2025.1.3.1 jetbrains.pycharm-professional: 2025.1.2 -> 2025.1.3.1 jetbrains.rider: 2025.1.2 -> 2025.1.4 jetbrains.ruby-mine: 2025.1.2 -> 2025.1.4.1 jetbrains.rust-rover: 2025.1.3 -> 2025.1.5 jetbrains.webstorm: 2025.1.2 -> 2025.1.4.1
|
Tested |
|
|
Also tested |
|
|
theCapypara
left a comment
There was a problem hiding this comment.
Thanks ners! In general this good to merge for me now, however I'm not sure if we have a plan on how to proceed with the -src build errors on aarch64. #425814 is closed now, is there a follow-up PR for that? I'm guessing the -src builds are broken on unstable too and it's unrelated to this PR - does somebody know or should we re-check that before merging?
|
The aarch64 build failure should be addressed by #430439 |
Things done
Fixes #425328
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.