Skip to content

ciscoPakcetTracer{7,8}: fix build#418679

Merged
khaneliman merged 2 commits intoNixOS:masterfrom
gepbird:packet-tracer-fix-build
Jun 21, 2025
Merged

ciscoPakcetTracer{7,8}: fix build#418679
khaneliman merged 2 commits intoNixOS:masterfrom
gepbird:packet-tracer-fix-build

Conversation

@gepbird
Copy link
Contributor

@gepbird gepbird commented Jun 21, 2025

Fixes #418660 and the same problem with version 7 of this package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 21, 2025
@gepbird gepbird marked this pull request as ready for review June 21, 2025 09:44
@gepbird gepbird requested review from griffi-gh and ryand56 June 21, 2025 09:44
@gepbird gepbird changed the title ciscoPakcetTracer8: fix build ciscoPakcetTracer{7,8}: fix build Jun 21, 2025
@github-actions github-actions bot removed the 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. label Jun 21, 2025
Copy link
Member

@ryand56 ryand56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 418679
Commit: 982c8d0bc787b6e96303954ffc79e0a75ce1751c


x86_64-linux

✅ 2 packages built:
  • ciscoPacketTracer7
  • ciscoPacketTracer8

@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 21, 2025
@khaneliman khaneliman merged commit ba953a0 into NixOS:master Jun 21, 2025
29 of 33 checks passed
@gepbird gepbird deleted the packet-tracer-fix-build branch June 21, 2025 23:21
@Soveu Soveu mentioned this pull request Jun 30, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: ciscoPacketTracer8

3 participants