Skip to content

plex-desktop: fix build#418546

Merged
khaneliman merged 1 commit intoNixOS:masterfrom
gepbird:plex-desktop-fix-build
Jun 21, 2025
Merged

plex-desktop: fix build#418546
khaneliman merged 1 commit intoNixOS:masterfrom
gepbird:plex-desktop-fix-build

Conversation

@gepbird
Copy link
Contributor

@gepbird gepbird commented Jun 20, 2025 •
edited
Loading 

plex-desktop> error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/q4g7nhi0p1qwz3v85sdxznk614f5ks94-plex-desktop-1.109.0/lib/libQt6WebEngineCore.so.6
plex-desktop> error: auto-patchelf could not satisfy dependency libxml2.so.2 wanted by /nix/store/q4g7nhi0p1qwz3v85sdxznk614f5ks94-plex-desktop-1.109.0/lib/libxslt.so.1

I'm suspecting that #396195 is the culprit, but libxml2 package wasn't a direct dependency through nix so I'm not sure, I'll keep investigating why did the build break, so maybe there's a better solution

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 20, 2025
@nix-owners nix-owners bot requested a review from detroyejr June 20, 2025 21:23
@gepbird gepbird force-pushed the plex-desktop-fix-build branch from 072f0fd to 04eb60b Compare June 20, 2025 21:46
@khaneliman
Copy link
Contributor

khaneliman commented Jun 20, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 418546
Commit: 04eb60b51b1c6310d1768f41cb5c4b004911dee8

x86_64-linux

✅ 1 package built:
  • plex-desktop

khaneliman
khaneliman approved these changes Jun 20, 2025
View reviewed changes
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and app works. Seems similar to what I ran into with citrix-workspace with libxml2 change.

@gepbird gepbird marked this pull request as draft June 20, 2025 22:20
@github-actions github-actions bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 20, 2025
@gepbird gepbird marked this pull request as ready for review June 20, 2025 22:41
@gepbird
Copy link
Contributor Author

gepbird commented Jun 20, 2025 •
edited
Loading

There were some breaking changes in https://discourse.gnome.org/t/libxml2-2-14-0-released/28025, including an soname bump (libxml2.so.2 -> libxml2.so.16), which is the source of the original error

Using the latest and nixpkgs-build libxml2 will result in other errors (like no version information available in citrix-workspace and a segfault in the end), the newer version is incompatible. Using the prebuild binary is probably the best until upstream bumps libxml2

@gepbird gepbird mentioned this pull request Jun 21, 2025
Closed
3 tasks
@khaneliman khaneliman merged commit 951c83d into NixOS:master Jun 21, 2025
30 of 31 checks passed
gepbird added a commit to tchfoo/raspi-dotfiles that referenced this pull request Jun 22, 2025
@gepbird
flake.lock: Update
26f7b32 
Flake lock file updates:

• Updated input 'agenix':
    'github:ryantm/agenix/4835b1dc898959d8547a871ef484930675cb47f1' (2025-05-18)
  → 'github:ryantm/agenix/531beac616433bac6f9e2a19feb8e99a22a66baf' (2025-06-17)
• Updated input 'gep-dotfiles':
    'github:gepbird/dotfiles/004c902c7698a638ddb1b464292a066f10b9b2eb' (2025-06-16)
  → 'github:gepbird/dotfiles/afa3f1d0ae1ec3ac6a2c8c4c4b43d402c5b26227' (2025-06-22)
• Updated input 'home-manager':
    'github:nix-community/home-manager/0edffd088e42fdc48598b37d88eb5345e2ca3937' (2025-06-16)
  → 'github:nix-community/home-manager/863842639722dd12ae9e37ca83bcb61a63b36f6c' (2025-06-19)
• Updated input 'nixos-hardware':
    'github:NixOS/nixos-hardware/61837d2a33ccc1582c5fabb7bf9130d39fee59ad' (2025-06-16)
  → 'github:NixOS/nixos-hardware/1552a9f4513f3f0ceedcf90320e48d3d47165712' (2025-06-20)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/ee930f9755f58096ac6e8ca94a1887e0534e2d81' (2025-06-13)
  → 'github:NixOS/nixpkgs/08f22084e6085d19bcfb4be30d1ca76ecb96fe54' (2025-06-19)
• Updated input 'uni-week-counter':
    'github:ymstnt/uni-week-counter/90f9f32c65d9b8571d3cbb11a9e68316acd1c83b' (2025-06-19)
  → 'github:ymstnt/uni-week-counter/dbbbe7a7d5e6f8cc5a09fd076b1bd45b1241169b' (2025-06-19)
• Updated input 'ymstnt-dotfiles':
    'github:ymstnt/dotfiles/f8d3d0164c1ef2f0b55cb75a86a41e9cbcf4d8ff' (2025-06-15)
  → 'github:ymstnt/dotfiles/4547253b3c5de2b8474353ecd4c6099bbb066f5d' (2025-06-21)
• Added input 'ymstnt-dotfiles/nixpkgs-patch-plex-desktop-fix-build':
    'NixOS/nixpkgs#418546'
• Added input 'ymstnt-dotfiles/nixpkgs-patcher':
    follows ''
@detroyejr detroyejr mentioned this pull request Jun 26, 2025
Merged
13 tasks
@gepbird gepbird mentioned this pull request Jul 2, 2025
Merged
13 tasks
@gepbird gepbird deleted the plex-desktop-fix-build branch July 2, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaneliman khaneliman khaneliman approved these changes

@detroyejr detroyejr Awaiting requested review from detroyejr

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gepbird @khaneliman