librashader: fix building with stable rust#418382
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Jun 20, 2025
Merged
Conversation
13 tasks
Prince213
added
0.kind: bug
github-actions
bot
added
10.rebuild-darwin: 1-10
Member
Author
|
nadiaholmquist
approved these changes
Jun 20, 2025
github-actions
bot
added
12.approvals: 1
Aleksanaa
reviewed
Jun 20, 2025
Prince213
force-pushed
the
push-pyulooorolnx
branch
from
619a6a8 to
69fd391
Compare
Member
Author
|
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are building the package with stable rust so we should follow https://github.com/SnowflakePowered/librashader?tab=readme-ov-file#building-against-stable-rust.
The generate header doesn't have necessary #if guards which causes ares build failure.
This PR fixes that and thus fixes building ares.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.