Skip to content

fctix5 packages and module update#417815

Merged
NickCao merged 16 commits intoNixOS:masterfrom
Vonfry:fctix5-5.1.13
Aug 26, 2025
Merged

fctix5 packages and module update#417815
NickCao merged 16 commits intoNixOS:masterfrom
Vonfry:fctix5-5.1.13

Conversation

@Vonfry
Copy link
Member

@Vonfry Vonfry commented Jun 18, 2025 •
edited
Loading

changelog

Highlight

fcitx5-configtool is only based on qt6 now, so I remove qt5 support in nixos module. fcitx5-qt can work with qt5 as before.
Ones who want to use qt5 version's fcitx5, should wrap it manually with addons by overriding it without fcitx5-configtool.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@Vonfry Vonfry requested a review from NickCao June 18, 2025 12:04
@nix-owners nix-owners bot requested review from ElnuDev, wattmto and xrelkd June 18, 2025 12:12
@Aleksanaa Aleksanaa changed the title fctix5 packages uand module update fctix5 packages and module update Jun 18, 2025
@nix-owners nix-owners bot requested a review from poscat0x04 June 18, 2025 12:12
@nix-owners nix-owners bot requested review from Technical27 and berberman June 18, 2025 12:12
Aleksanaa
Aleksanaa reviewed Jun 18, 2025
View reviewed changes
@wolfgangwalther

This comment was marked as resolved.

Sign in to view
@MattSturgeon

This comment was marked as resolved.

Sign in to view
@Aleksanaa Aleksanaa mentioned this pull request Jun 18, 2025
Closed
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: documentation This PR adds or changes documentation labels Jun 18, 2025
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 19, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jun 19, 2025
@Vonfry
Copy link
Member Author

Vonfry commented Jun 23, 2025 •
edited
Loading

Update:

  1. fix building issues on qt6Packages.fcitx5-chinese-addons.
  2. remove qt5Packages.fcitx5-configtool and qt5Packages.fcitx5-chinese-addons, which only supports on qt6 now. They are kept, because some other packages depended on them, though they are failed to build.

Vonfry added 12 commits August 19, 2025 19:17
@Vonfry
fcitx5-anthy: 5.1.6 -> 5.1.7
fbdda4b
@Vonfry
fcitx5-chewing: 5.1.7 -> 5.1.8
6aa960d 
Diff: fcitx/fcitx5-chewing@5.1.7...5.1.8
@Vonfry
fcitx5-chinese-addons: 5.1.8 -> 5.1.9
12e154e 
Diff: fcitx/fcitx5-chinese-addons@5.1.8...5.1.9
@Vonfry
fcitx5-configtool: 5.1.9 -> 5.1.10
1bea7d2 
Diff: fcitx/fcitx5-configtool@5.1.9...5.1.10
@Vonfry
fcitx5-hangul: 5.1.6 -> 5.1.7
21421ab 
Diff: fcitx/fcitx5-hangul@5.1.6...5.1.7
@Vonfry
fcitx5-lua: 5.0.14 -> 5.0.15
9786f37 
Diff: fcitx/fcitx5-lua@5.0.14...5.0.15
@Vonfry
fcitx5-m17n: 5.1.3 -> 5.1.4
7ad806d 
Diff: fcitx/fcitx5-m17n@5.1.3...5.1.4
@Vonfry
libsForQt5.fcitx5-qt: 5.1.9 -> 5.1.10
cec68a0 
Diff: fcitx/fcitx5-qt@5.1.9...5.1.10
@Vonfry
fcitx5-rime: 5.1.10 -> 5.1.11
92f39ac
@Vonfry
fcitx5-skk: 5.1.6 -> 5.1.7
647e6ec 
Diff: fcitx/fcitx5-skk@5.1.6...5.1.7
@Vonfry
fcitx5-unikey: 5.1.6 -> 5.1.7
0729c91 
Diff: fcitx/fcitx5-unikey@5.1.6...5.1.7
@Vonfry
fcitx5: 5.1.13 -> 5.1.14
7e14cfe 
Diff: fcitx/fcitx5@5.1.13...5.1.14
@Vonfry Vonfry force-pushed the fctix5-5.1.13 branch 3 times, most recently from b811cd6 to 0eba9e7 Compare August 19, 2025 12:05
@Vonfry Vonfry requested a review from NickCao August 19, 2025 12:06
NickCao
NickCao reviewed Aug 19, 2025
View reviewed changes
@Vonfry Vonfry requested a review from NickCao August 20, 2025 11:26
@NickCao
Copy link
Member

NickCao commented Aug 21, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 417815
Commit: 01fc72b3566368a219470f4ac0b456216cf5ba29

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • fcitx5-openbangla-keyboard
✅ 26 packages built:
  • fcitx5
  • fcitx5-anthy
  • fcitx5-bamboo
  • fcitx5-chewing
  • fcitx5-gtk
  • fcitx5-gtk.dev
  • fcitx5-hangul
  • fcitx5-lua
  • fcitx5-m17n
  • fcitx5-mcbopomofo
  • fcitx5-mozc
  • fcitx5-mozc-ut
  • fcitx5-rime
  • fcitx5-skk
  • fcitx5-table-extra
  • fcitx5-table-other
  • kdePackages.fcitx5-chinese-addons (qt6Packages.fcitx5-chinese-addons)
  • kdePackages.fcitx5-configtool (qt6Packages.fcitx5-configtool)
  • kdePackages.fcitx5-qt (qt6Packages.fcitx5-qt)
  • kdePackages.fcitx5-skk-qt (qt6Packages.fcitx5-skk-qt)
  • kdePackages.fcitx5-unikey (qt6Packages.fcitx5-unikey)
  • kdePackages.fcitx5-with-addons (qt6Packages.fcitx5-with-addons)
  • libime
  • libsForQt5.fcitx5-qt (plasma5Packages.fcitx5-qt)
  • mlterm
  • mlterm-wayland
Error logs: `x86_64-linux`
fcitx5-openbangla-keyboard 
[ 63%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/SingleInstance.cpp.o
[ 66%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/AvroPhonetic.cpp.o
[ 70%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/TopBar.cpp.o
[ 73%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/AboutDialog.cpp.o
[ 76%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/AboutFile.cpp.o
[ 80%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/LayoutViewer.cpp.o
[ 83%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/SettingsDialog.cpp.o
/build/source/src/frontend/LayoutViewer.cpp: In member function 'QByteArray LayoutViewer::decodeAndDecompress(QByteArray&)':
/build/source/src/frontend/LayoutViewer.cpp:114:52: warning: 'long long unsigned int ZSTD_getDecompressedSize(const void*, size_t)' is deprecated [8;;https://gcc.gnu.org/onlinedocs/gcc-14.3.0/gcc/Warning-Options.html#index-Wdeprecated-declarations-Wdeprecated-declarations8;;]
  114 |   unsigned long long cap = ZSTD_getDecompressedSize(decoded.data(), decoded.size());
      |                            ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /build/source/src/frontend/LayoutViewer.cpp:21:
/nix/store/6rdhi9vyk3h67nhkwl0n7q0b6hl3xiza-zstd-1.5.7-dev/include/zstd.h:214:32: note: declared here
  214 | ZSTDLIB_API unsigned long long ZSTD_getDecompressedSize(const void* src, size_t srcSize);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~
[ 86%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/AutoCorrectDialog.cpp.o
[ 90%] Building CXX object src/frontend/CMakeFiles/openbangla-gui.dir/openbangla-gui_autogen/EWIEGA46WW/qrc_images.cpp.o
[ 93%] Linking CXX executable openbangla-gui
[ 96%] Built target openbangla-gui
make: *** [Makefile:156: all] Error 2

@Vonfry
Copy link
Member Author

Vonfry commented Aug 23, 2025

Should I fix openbangla-keyboard in this pr? That package hasn't been updated in several years and no stable release as well.

Let me cc the maintainer: @hqurve and @eclairevoyant who commited on fcitx5 support.

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Aug 23, 2025

Should I fix openbangla-keyboard in this pr?

Looks like upstream is still active, I guess it'd be good to set up an update script for it.

No opinion on whether it has to be in this PR or not, unless this PR specifically breaks it.

@NickCao NickCao merged commit 1b7a161 into NixOS:master Aug 26, 2025
24 checks passed
@NickCao NickCao mentioned this pull request Aug 26, 2025
Closed
13 tasks
@Vonfry Vonfry deleted the fctix5-5.1.13 branch August 27, 2025 01:36
@psynyde
Copy link

psynyde commented Sep 12, 2025

any updates on the fcitx5-openbangla-keyboard package? D:

@Vonfry
Copy link
Member Author

Vonfry commented Sep 12, 2025 via email

@eclairevoyant eclairevoyant mentioned this pull request Dec 15, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrelkd xrelkd Awaiting requested review from xrelkd

@ElnuDev ElnuDev Awaiting requested review from ElnuDev

@wattmto wattmto Awaiting requested review from wattmto

@poscat0x04 poscat0x04 Awaiting requested review from poscat0x04

@Technical27 Technical27 Awaiting requested review from Technical27

@berberman berberman Awaiting requested review from berberman

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@NickCao NickCao Awaiting requested review from NickCao

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Vonfry @wolfgangwalther @MattSturgeon @Aleksanaa @NickCao @eclairevoyant @psynyde