Skip to content

libavif: avoid dev dependencies for depending binaries#417080

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:libavif-dev
Jun 30, 2025
Merged

libavif: avoid dev dependencies for depending binaries#417080
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000:libavif-dev

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Jun 15, 2025 •
edited
Loading

Tested by building gd, gdal, dav1d and pillow.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from mkg20001 June 15, 2025 22:52
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 15, 2025
@SuperSandro2000 SuperSandro2000 merged commit 095e78b into NixOS:staging Jun 30, 2025
17 of 18 checks passed
@SuperSandro2000 SuperSandro2000 deleted the libavif-dev branch June 30, 2025 12:36
@K900 K900 mentioned this pull request Jul 6, 2025
Merged
13 tasks
@K900
Copy link
Contributor

K900 commented Jul 6, 2025

This broke cmake files as they point to the old header location.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jul 6, 2025

Did I manage to only pick out autoconf... I'll take a look.

@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented Jul 12, 2025

I couldn't find the upstream code which generates the broken cmake code, so I just patched it in. #424658

@Rhys-T Rhys-T mentioned this pull request Jul 19, 2025
Closed
3 tasks
@fgaz fgaz mentioned this pull request Jul 19, 2025
Merged
@heitorPB heitorPB mentioned this pull request Jul 22, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkg20001 mkg20001 Awaiting requested review from mkg20001

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @K900