ci/treefmt: add yamlfmt#416115
Conversation
github-actions
bot
added
6.topic: julia
github-actions
bot
added
10.rebuild-darwin: 0
|
nix-owners
bot
requested review from
LeSuisse,
Mic92,
SigmaSquadron,
azuwis,
infinisil,
mweinelt,
philiptaron,
risicle and
zowoq
|
I'm recusing myself from this review because it involves thinking about the format of YAML. |
|
Well, that's kind of the point of this PR: To not have to think about formatting yaml for workflow files anymore. treefmt will do it. :) |
SigmaSquadron
left a comment
SigmaSquadron
left a comment
There was a problem hiding this comment.
If at all possible, I'd like to see two commits: one for the treewide format, and another that actually adds the yamlfmt configuration to treefmt-nix
This applies changes from running yamlfmt with the `retain_line_breaks` formatting option enabled.
Most workflow files are already well formatted, but to make it easier to keep it that way, we can add yamlfmt. I personally have a preference for non-indented arrays for YAML, but wanted to avoid bigger diffs here - the status-quo clearly are indented arrays. Some changes are made manually to the get-merge-commit action and the issue templates. Those would otherwise make yamlfmt misbehave on those.
wolfgangwalther
force-pushed
the
ci-treefmt-yamlfmt
branch
from
2017655 to
8ec23df
Compare
|
Right, good point. This should make it easier to review. Especially because some of the changes are not auto-generated, but were done by hand - I left those in the second commit. |
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
I said I was recusing myself but evidently I can hold my nose and read about YAML on a Friday.
https://yaml-multiline.info/ is cursed knowledge but I guess not totally cursed.
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-416115-to-release-24.11 origin/release-24.11
cd .worktree/backport-416115-to-release-24.11
git switch --create backport-416115-to-release-24.11
git cherry-pick -x 66981875e8cb8ab8a4bd0eb54bd1371de91d084d 8ec23df6f6c8e647719cbbded5376fd83679a28b |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-416115-to-release-25.05 origin/release-25.05
cd .worktree/backport-416115-to-release-25.05
git switch --create backport-416115-to-release-25.05
git cherry-pick -x 66981875e8cb8ab8a4bd0eb54bd1371de91d084d 8ec23df6f6c8e647719cbbded5376fd83679a28b |
|
Of course, I should have rebased before merge. Two other formatting nits were introduced on master meanwhile, fixed in #416919. |
wolfgangwalther
added
the
8.has: port to stable
3 participants
Most workflow files are already well formatted, but to make it easier to keep it that way, we can add yamlfmt.
I personally have a preference for non-indented arrays for YAML, but wanted to avoid bigger diffs here - the status-quo clearly are indented arrays.
Things done
Add a 👍 reaction to pull requests you find important.