net-tools: rename from nettools#416056
Conversation
github-actions
bot
added
6.topic: python
nix-owners
bot
requested review from
6543,
adamcstephens,
amarshall,
arianvp,
maralorn,
sternenseemann and
wolfgangwalther
github-actions
bot
added
10.rebuild-darwin: 101-500
|
Sadly your commit touches the autogenerated hackage-packages.nix file. Annoyingly changing this would require modifying this line: https://github.com/NixOS/cabal2nix/blob/0caafdd58fa45228b2abc67078f239c85df21b89/cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/PostProcess.hs#L140 I have never heard of this program and it is broken, so probably the cheapest fix to eval is fine. |
The package is broken and has a dependency on nettools, which I want to rename in NixOS/nixpkgs#416056
6543
left a comment
6543
left a comment
There was a problem hiding this comment.
I'm neither for nor against it ... so for my module just lgtm/rejeckt on what the majority of maintainers of this rename think.
as for my two cents: please dont bikeshed :) - it it's good it is else well let it be ?!?
|
I'm not sure why this causes as many darwin rebuilds. They were already there before cabal2nix was bumped, so unrelated to that. I went through the diff once, and nothing stood out. |
pkgs/top-level/unixtools.nix
Outdated
There was a problem hiding this comment.
I think this causes the rebuilds via name = "${pname}-${version}"; above.
github-actions
bot
added
the
12.approvals: 1
|
Should go to staging with this rebuild since the change is not particularly urgent. |
By being in sync with the pname, it makes it easier to walk back from the pname that shows in the /nix/store back to the attribute. This change should not cause any rebuild.
Includes the nettool patch
…S#416056) This commit has been generated by maintainers/scripts/haskell/regenerate-hackage-packages.sh --fast
zimbatm
force-pushed
the
rename-net-tools
branch
from
935427f to
08c7dcb
Compare
|
Ok it's ready! |
5 participants
By being in sync with the pname, it makes it easier to walk back from
the pname that shows in the /nix/store back to the attribute.
This change should not cause any rebuild.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.