Skip to content

librashader: 0.6.2 -> 0.8.1#414940

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
Prince213:push-syovpwxvzzzp
Jun 18, 2025
Merged

librashader: 0.6.2 -> 0.8.1#414940
vcunat merged 1 commit intoNixOS:staging-nextfrom
Prince213:push-syovpwxvzzzp

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Jun 8, 2025

Release notes:

Hydra failure: https://hydra.nixos.org/build/298693862

This requires 1.87 so it needs to target staging-next.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Prince213 Prince213 added 0.kind: bug Something is broken 8.has: package (update) This PR updates a package to a newer version 0.kind: build failure A package fails to build labels Jun 8, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 8, 2025
alyssais
alyssais approved these changes Jun 9, 2025
View reviewed changes
Copy link
Member

@alyssais alyssais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Don't know anything about the package.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 9, 2025
@nadiaholmquist
Copy link
Contributor

nadiaholmquist commented Jun 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 414940
Commit: 8e207e841a5133d30ad0527ce85c4540786f18e1

aarch64-darwin

❌ 1 package failed to build:
  • ares
✅ 1 package built:
  • librashader
Error logs: `aarch64-darwin`
ares 
      |                                ^
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/hiro.mm:1:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/hiro.cpp:5:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/core/core.cpp:23:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/core/../cocoa/platform.cpp:39:
/tmp/nix-build-ares-144.drv-0/source/hiro/core/../cocoa/widget/hex-edit.cpp:110:4: warning: local declaration of 'tableView' hides instance variable [-Wshadow-ivar]
  110 |   [tableView reloadData];
      |    ^
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/hiro.mm:1:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/hiro.cpp:5:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/core/core.cpp:23:
In file included from /tmp/nix-build-ares-144.drv-0/source/hiro/core/../cocoa/platform.cpp:58:
/tmp/nix-build-ares-144.drv-0/source/hiro/core/../cocoa/widget/viewport.cpp:64:69: warning: 'NSFilenamesPboardType' is deprecated: first deprecated in macOS 10.14 - Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead [-Wdeprecated-declarations]
   64 |     [cocoaViewport registerForDraggedTypes:[NSArray arrayWithObject:NSFilenamesPboardType]];
      |                                                                     ^
/nix/store/p9kkihbhakgw209d02xq24vw5z8ff8bc-apple-sdk-14.4/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/AppKit.framework/Headers/NSPasteboard.h:312:32: note: 'NSFilenamesPboardType' has been explicitly marked deprecated here
  312 | APPKIT_EXTERN NSPasteboardType NSFilenamesPboardType API_DEPRECATED("Create multiple pasteboard items with NSPasteboardTypeFileURL or kUTTypeFileURL instead", macos(10.0,10.14));
      |                                ^
7 warnings generated.
ninja: build stopped: subcommand failed.

@nadiaholmquist
Copy link
Contributor

nadiaholmquist commented Jun 11, 2025

librashader package itself looks good to me, but ares (the only user of the package currently) doesn't seem to build with this version?

@vcunat vcunat merged commit 0b7191a into NixOS:staging-next Jun 18, 2025
21 of 22 checks passed
@vcunat
Copy link
Member

vcunat commented Jun 18, 2025

I guess this is better than neither building.

@Prince213
Copy link
Member Author

Prince213 commented Jun 18, 2025

Thanks!

@Prince213
Copy link
Member Author

Prince213 commented Jun 20, 2025

librashader package itself looks good to me, but ares (the only user of the package currently) doesn't seem to build with this version?

@nadiaholmquist this will be resolved by #418382.

@Prince213 Prince213 deleted the push-syovpwxvzzzp branch June 27, 2025 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais alyssais approved these changes

@nadiaholmquist nadiaholmquist Awaiting requested review from nadiaholmquist

Assignees

No one assigned

Labels

0.kind: bug Something is broken 0.kind: build failure A package fails to build 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Prince213 @nadiaholmquist @vcunat @alyssais @wegank