Skip to content

minimal-bootstrap: fix the eval (rewriteURL fallout)#414769

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
trofi:minimal-bootstrap-fix-eval
Jun 7, 2025
Merged

minimal-bootstrap: fix the eval (rewriteURL fallout)#414769
philiptaron merged 1 commit intoNixOS:masterfrom
trofi:minimal-bootstrap-fix-eval

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Jun 7, 2025

Without the change the eval fails as:

$ nix-instantiate -A minimal-bootstrap.bash --argstr system i686-linux
error:
   … while calling the 'derivationStrict' builtin
     at <nix/derivation-internal.nix>:37:12:
       36|
       37|   strict = derivationStrict drvAttrs;
         |            ^
       38|

   … while evaluating derivation 'bash-5.2.15'
     whose name attribute is located at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:85:19

   … while evaluating attribute 'PATH' of derivation 'bash-5.2.15'
     at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:108:11:
      107|           SHELL = "${bash_2_05}/bin/bash";
      108|           PATH = lib.makeBinPath (
         |           ^
      109|             (env.nativeBuildInputs or [ ])

   (stack trace truncated; use '--show-trace' to show the full, detailed trace)

   error: function 'anonymous lambda' called without required argument 'rewriteURL'
   at /tmp/nixpkgs/pkgs/build-support/fetchurl/boot.nix:5:1:
        4|
        5| {
         | ^
        6|   rewriteURL,

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix-instantiate -A minimal-bootstrap.bash --argstr system i686-linux
    error:
       … while calling the 'derivationStrict' builtin
         at <nix/derivation-internal.nix>:37:12:
           36|
           37|   strict = derivationStrict drvAttrs;
             |            ^
           38|

       … while evaluating derivation 'bash-5.2.15'
         whose name attribute is located at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:85:19

       … while evaluating attribute 'PATH' of derivation 'bash-5.2.15'
         at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:108:11:
          107|           SHELL = "${bash_2_05}/bin/bash";
          108|           PATH = lib.makeBinPath (
             |           ^
          109|             (env.nativeBuildInputs or [ ])

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: function 'anonymous lambda' called without required argument 'rewriteURL'
       at /tmp/nixpkgs/pkgs/build-support/fetchurl/boot.nix:5:1:
            4|
            5| {
             | ^
            6|   rewriteURL,
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 7, 2025
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough

@philiptaron philiptaron merged commit 7a43a66 into NixOS:master Jun 7, 2025
17 of 20 checks passed
@trofi trofi deleted the minimal-bootstrap-fix-eval branch June 7, 2025 18:59
Copy link
Contributor

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants