minimal-bootstrap: fix the eval (rewriteURL fallout)#414769
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Jun 7, 2025
Merged
minimal-bootstrap: fix the eval (rewriteURL fallout)#414769philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
Without the change the eval fails as:
$ nix-instantiate -A minimal-bootstrap.bash --argstr system i686-linux
error:
… while calling the 'derivationStrict' builtin
at <nix/derivation-internal.nix>:37:12:
36|
37| strict = derivationStrict drvAttrs;
| ^
38|
… while evaluating derivation 'bash-5.2.15'
whose name attribute is located at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:85:19
… while evaluating attribute 'PATH' of derivation 'bash-5.2.15'
at pkgs/os-specific/linux/minimal-bootstrap/bash/2.nix:108:11:
107| SHELL = "${bash_2_05}/bin/bash";
108| PATH = lib.makeBinPath (
| ^
109| (env.nativeBuildInputs or [ ])
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: function 'anonymous lambda' called without required argument 'rewriteURL'
at /tmp/nixpkgs/pkgs/build-support/fetchurl/boot.nix:5:1:
4|
5| {
| ^
6| rewriteURL,
14 tasks
jherland
reviewed
Jun 8, 2025
Contributor
jherland
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this!
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the change the eval fails as:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.