maintainers/scripts/remove-old-aliases: handle more complex cases#414664
Closed
pbsds wants to merge 3 commits intoNixOS:masterfrom
Closed
maintainers/scripts/remove-old-aliases: handle more complex cases#414664pbsds wants to merge 3 commits intoNixOS:masterfrom
pbsds wants to merge 3 commits intoNixOS:masterfrom
Conversation
Man this script is not very nice
github-actions
bot
added
10.rebuild-darwin: 0
nixpkgs-ci
bot
added
the
9.needs: reviewer
1 task
wegank
added
the
2.status: merge conflict
4 tasks
mdaniels5757
requested changes
Oct 12, 2025
Comment on lines
+85
to
+86
| elif '"' in line: | ||
| date_too_complex_list.append(f"{lineno:>5} {line}") |
Member
There was a problem hiding this comment.
What is this supposed to be doing? It has the effect of marking all throws (among other things) as too complex, which I'm sure wasn't your intent.
nixpkgs-ci
bot
removed
the
9.needs: reviewer
Contributor
|
Superseded by #427017. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inherit (x) y;This PR started as a
"aliases: throw aliases before 2023"but as i dug more and more i figured that we don't have a established schedule for when to drop aliases, nor do we communicate which attributes are at risk of being dropped to the end user. That chain of thought resulted in #414658 and the two other PRs it links to.Not feeling like I can safely any drop aliases in this current situation I instead pivoted this PR to just upstream the quick fixes I made to
maintainers/scripts/remove-old-aliases.py.This script is really not nice, I'd love to rewrite it but I have more pressing matters.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.