haskellPackages: fix GHC 9.12 on android #414317
Merged
alexfmpe merged 3 commits intoNixOS:haskell-updatesfrom Jul 13, 2025
Merged
haskellPackages: fix GHC 9.12 on android #414317alexfmpe merged 3 commits intoNixOS:haskell-updatesfrom
alexfmpe merged 3 commits intoNixOS:haskell-updatesfrom
Conversation
github-actions
bot
added
the
6.topic: haskell
nix-owners
bot
requested review from
maralorn,
sternenseemann and
wolfgangwalther
alexfmpe
force-pushed
the
ghc-9.12-android
branch
2 times, most recently
from
f19f494 to
ae12f30
Compare
alexfmpe
commented
Jun 5, 2025
Member
Author
There was a problem hiding this comment.
Deferring this to @angerman, these symbols need to be defined in the rts:
- see: https://github.com/input-output-hk/haskell.nix/blob/9e552b1dd53c420f26eeb647cd373e015eba0016/overlays/patches/ghc/ghc-define-undefined-elf-st-visibility.patch#L4
- and https://github.com/input-output-hk/haskell.nix/blob/9e552b1dd53c420f26eeb647cd373e015eba0016/overlays/bootstrap.nix#L245
Member
Author
There was a problem hiding this comment.
That's... the patch I'm applying here ?
I was asking whether it should be a GHC patch or there's something wrong with includes on android
Member
Author
There was a problem hiding this comment.
Derp, I reference it here but had forgotten to commit the file itself. git commit -a strikes again
github-actions
bot
added
10.rebuild-darwin: 0
alexfmpe
force-pushed
the
ghc-9.12-android
branch
from
ae12f30 to
fd70975
Compare
13 tasks
alexfmpe
force-pushed
the
ghc-9.12-android
branch
from
fd70975 to
bd26ccc
Compare
alexfmpe
force-pushed
the
ghc-9.12-android
branch
from
bd26ccc to
4fe25a0
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in input-output-hk/haskell.nix@08efe5b
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.