Skip to content

Revert "stalwart-mail: build against system jemalloc"#414235

Merged
yuyuyureka merged 1 commit intoNixOS:masterfrom
eyJhb:revert-stalwartmail
Jun 5, 2025
Merged

Revert "stalwart-mail: build against system jemalloc"#414235
yuyuyureka merged 1 commit intoNixOS:masterfrom
eyJhb:revert-stalwartmail

Conversation

@eyJhb
Copy link
Member

@eyJhb eyJhb commented Jun 5, 2025

After the changes done in #411265 , I'm unable to build Stalwart at all from the unstable branch. I've tried on multiple systems (Intel and AMD), and have had other people try without any success.

If I revert these changes, I can build without any errors.

Tagging original PR owner and committer:

Error log:

running 9 tests
test modules::html::tests::test_html_to_tokens_comment ... ok
test modules::html::tests::test_html_to_tokens_start_tag ... ok
test modules::html::tests::test_html_to_tokens_end_tag ... ok
test modules::html::tests::test_html_to_tokens_text ... ok
test modules::html::tests::test_html_to_tokens_mixed ... ok
test modules::pyzor::test::send_message ... ignored
test modules::html::tests::test_html_to_tokens_with_attributes ... ok
test modules::pyzor::test::message_pyzor ... ok
test modules::pyzor::test::digest_pyzor ... ok

test result: ok. 8 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/x86_64-unknown-linux-gnu/release/deps/stalwart-958a08e6dbe82a48)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/main.rs (target/x86_64-unknown-linux-gnu/release/deps/stalwart_cli-395efe8f936b92ea)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/x86_64-unknown-linux-gnu/release/deps/store-940b46dbbd812c2e)

running 2 tests
test fts::postings::tests::postings_match_positions ... ok
test write::bitpack::tests::bitpack_roundtrip ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running unittests src/lib.rs (target/x86_64-unknown-linux-gnu/release/deps/tests-16eaaaccff7c1ed9)
free(): invalid pointer
error: test failed, to rerun pass `-p tests --lib`

Caused by:
  process didn't exit successfully: `/build/source/target/x86_64-unknown-linux-gnu/release/deps/tests-16eaaaccff7c1ed9 '--skip=directory::imap::imap_directory' '--skip=directory::internal::internal_directory' '--skip=directory::ldap::ldap_directory' '--skip=directory::sql::sql_directory' '--skip=directory::oidc::oidc_directory' '--skip=store::blob::blob_tests' '--skip=store::lookup::lookup_tests' '--skip=smtp::lookup::sql::lookup_sql' '--skip=directory::smtp::lmtp_directory' '--skip=imap::imap_tests' '--skip=jmap::jmap_tests' '--skip=smtp::inbound::data::data' '--skip=smtp::inbound::scripts::sieve_scripts' '--skip=smtp::outbound::lmtp::lmtp_delivery' '--skip=smtp::outbound::extensions::extensions' '--skip=smtp::outbound::smtp::smtp_delivery' '--skip=smtp::outbound::lmtp::lmtp_delivery' '--skip=smtp::queue::retry::queue_retry' '--skip=store::store_tests' '--skip=cluster::cluster_tests' '--skip=webdav::webdav_tests' '--skip=config::parser::tests::toml_parse' '--skip=backend::sqlite::pool::SqliteConnectionManager::with_init' '--skip=smtp::reporting::analyze::report_analyze' '--skip=smtp::inbound::dmarc::dmarc' '--skip=smtp::queue::concurrent::concurrent_queue' '--skip=smtp::inbound::auth::auth' '--skip=smtp::inbound::antispam::antispam' '--skip=smtp::inbound::vrfy::vrfy_expn' '--skip=smtp::management::queue::manage_queue'` (signal: 6, SIGABRT: process abort signal)

Things done

Reverted changes made in #411265

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 5, 2025
@yuyuyureka
Copy link
Contributor

It passed in ofborg at the time.

Sad...

@yuyuyureka yuyuyureka merged commit cf5377c into NixOS:master Jun 5, 2025
16 of 19 checks passed
@eyJhb
Copy link
Member Author

eyJhb commented Jun 5, 2025

It passed in ofborg at the time.

Sad...

Yeah, that's kind of annoying. I'm uncertain what exactly made it pass, but fail on my system + other systems. I know my friend tried to compile it at least two times on his system, and I did the same, and the same on my server. But either way, I appreciate the hard work you've put into the PR, and your prompt response on this PR as well. Hopefully it can be fixed in the future :)

Feel free to ping me, if you give it another shot, and need me to build it in the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants