buildGraalvmNativeImage: switch to lib.extendMkDerivation#413663
Merged
philiptaron merged 13 commits intoNixOS:masterfrom Jun 10, 2025
Merged
buildGraalvmNativeImage: switch to lib.extendMkDerivation#413663philiptaron merged 13 commits intoNixOS:masterfrom
philiptaron merged 13 commits intoNixOS:masterfrom
Conversation
Contributor
Author
|
13 tasks
philiptaron
requested changes
Jun 3, 2025
Contributor
philiptaron
left a comment
There was a problem hiding this comment.
We want to use lib.extendMkDerivation. I'm going to make a PR against your branch...
| openjdk_headless = jdk_headless; | ||
|
|
||
| graalvmPackages = recurseIntoAttrs (callPackage ../development/compilers/graalvm { }); | ||
| buildGraalvmNativeImage = |
16 tasks
Contributor
|
Done: bengsparks#1 |
Co-authored-by: Philip Taron <[email protected]>
Also rewrite the update script to reflect that src is just a jar
Contributor
Author
|
philiptaron
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#412768's eval breaks because
executable ? args.pnamefails due tobuildGraalvmNativeImagedefaultingmeta.mainProgramtoexecutable.The error message reads:
This is surprising, as every package that uses
buildGraalvmNativeImagesupplies thepnamefield, as it is just a wrapper aroundstdenv.mkDerivation.I suspect the combination of
lib.intersectAttrsincallPackage(With)atnixpkgs/lib/customisation.nix
Line 247 in 054144e
buildGraalvmNativeImage = (callPackage ../build-support/build-graalvm-native-image { }.override)is to blame, but I cannot be sure.Due to the change in the
buildGraalvmNativeImagefunction, I don't think it's possible to make this a 0-rebuild PR.I tested this PR by
versionCheckProgramtomainProgram#412768I have also applied
diffoscopeto all of the packages thatnixpkgs-review rev HEADprinted on my system, and all seem to have remained identical, but I'm not entirely confident, as it seems there are minimal changes in some .JAR files, but all files seem to be present.If anyone has recommendations for options to tweak in
diffoscope, let me know 😄Here is the body of the script
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.