Skip to content

[staging-next] gcc14: fix build on aarch64-darwin#412977

Merged
emilazy merged 1 commit intoNixOS:staging-nextfrom
leona-ya:push-xynvmryxxsmz
Jun 1, 2025
Merged

[staging-next] gcc14: fix build on aarch64-darwin#412977
emilazy merged 1 commit intoNixOS:staging-nextfrom
leona-ya:push-xynvmryxxsmz

Conversation

@leona-ya
Copy link
Member

@leona-ya leona-ya commented Jun 1, 2025

The previous patch didn't apply anymore for 14.3.0.
Currently there is no branch for 14.3.0 in https://github.com/iains/gcc-14-branch nor in homebrew. This lead me to use the -pre branch with a custom target.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The previous patch didn't apply anymore for 14.3.0.
Currently there is no branch for 14.3.0 in https://github.com/iains/gcc-14-branch
nor in homebrew. This lead me to use the -pre branch with a custom target.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 1, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 1, 2025
@vcunat
Copy link
Member

vcunat commented Jun 1, 2025

I confirm it builds.

@leona-ya leona-ya requested review from emilazy, reckenrode and toonn June 1, 2025 17:49
@leona-ya
Copy link
Member Author

leona-ya commented Jun 1, 2025

I now build up to a ghc on aarch64-darwin with this gcc. It seems to work fine for this.

@emilazy emilazy merged commit 6eac0d4 into NixOS:staging-next Jun 1, 2025
16 of 19 checks passed
@leona-ya leona-ya deleted the push-xynvmryxxsmz branch June 1, 2025 18:03
@vcunat vcunat mentioned this pull request Jun 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants