jetbrains: rename pycharm-professional to pycharm, prepare community deprecation#412971
jetbrains: rename pycharm-professional to pycharm, prepare community deprecation#412971theCapypara wants to merge 4 commits intoNixOS:masterfrom
Conversation
|
Hm, adding the warnings makes the evaluation fail, so I'm guessing that warnings are not allowed for normal packages. In that case should we just not warn about this and only "break" things once we remove PyCharm Community? I thought a bit of a heads up for users would be nice, but please let me know of better ways to do this. One idea I have is that we could replace |
|
@GenericNerdyUsername @tymscar added your review request since you are maintainers. For some reasons it seems that the GitHub Actions do not properly detect this (but maybe this is expected and they just work via CODEOWNERS, I don't actually remember :) ) |
| fromSource = true; | ||
| }; | ||
| # TODO: Replace with alias (see bottom) once pycharm-src is available. | ||
| pycharm-community-bin = |
There was a problem hiding this comment.
This would pass CI if you only define these if config.allowAliases is true.
There was a problem hiding this comment.
Oh, I see the commented out block below. Don't think there is a way to have a soft warning, unfortunately.
nixpkgs-ci
bot
added
the
2.status: merge conflict
| pname = "pycharm-community"; | ||
| }); | ||
|
|
||
| # TODO: Replace with alias (see bottom) once pycharm-src is available. |
There was a problem hiding this comment.
Is this TODO comment implying there is no way for a user to "resolve" the warning on their end? (At least, without switching to the -bin package)
If so, I would hold off on adding the warning until we can add an alias, then use the alias itself as the trigger for the warning.
Unless it is possible that pycharm-src will never be available, in which case I'd move the entire package into the allowAliases set, and consider it "deprecated".
Note: that allowAliases is used for deprecated, renamed, and removed packages; not just actual aliases.
|
I have not gotten a response from Jetbrains yet, internal issue is IJPL-190285. I will update this PR once I get a reply or something is clarified publicly. |
|
I still haven't go a response, but they have changed their wording in the FAQ:
I read this as there being no longer a PyCharm Community Edition directly, but "just" the ability to build what was previously included in PyCharm Community Edition yourself. I'm still not sure if the Python plugin that is the base for this is the same across PyCharm and the OSS code, but I think so. My suggestion would be to still proceed as suggested in the PR description. Does that sound good? Then I would fixup this PR. |
|
I learned today that this also affects IDEA. There is only one product now, with OSS still buildable but just as with PyCharm I'm not sure what that entirely means. From the graphic below it seems like the OSS versions are something different than what community was. With that it might make more sense to name them Does anybody know more or has thoughts about my proposal above? @leona-ya @thiagokokada @jamesward We also really should remove the discontinued IDEs. I suggest we move forward to have things switched over for 26.05. We could also do this for 25.11 even if that releases next week, since otherwise I could see this as hard to maintain next cycle if we support unstable with the changes and 25.11 without... |
SGTM. My preference would be to make Otherwise, if you don't want to do an alias, making the old names Either way, an alias that warns or an attr that throws should only be defined when An alternative naming scheme would be to have That'd be a bit harder to implement renames/warnings for, since the existing (e.g.) |
|
Opened a new PR: #466331 |
3 participants
This renames
pycharm-professionaltopycharm-bin, introducespycharmas an alias forpycharm-binand deprecatespycharm-community{+ -bin & -src}in preperation to replace them withpycharm-binandpycharm-src.In order for the last thing to happen, Jetbrains needs to provide instructions on how to actually build PyCharm (NOT the deprecated PyCharm Community) from source. I have reached out to them for that.
It is also possible that Jetbrains doesn't actually plan to release PyCharm as open source but just keep providing PyCharm Community from source. That would be pretty confusing though, and I'm not sure if they'll then still make new releases? I asked them about this as well. In any case it seems that
pycharm-binwouldn't be the same aspycharm-srceven if they did release PyCharm as OSS, sincepycharm-binnow contains propreitary code. So we would need to later keeppycharm-binmarked as unfree andpycharm-srcas OSS.I added a bunch of TODO items for things to do once we can make the switch for
pycharm-community->pycharm.This also fixes the issue of plugins no longer being detected and built for PyCharm Community (#412715).
IMO this should be backported to 25.05 even if it introduces warnings for existing packages, since Jetbrains has stopped developing PyCharm Community and will only provide one more release.
But also changes like this are new for me, so let me know if I screwed anything up :)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.