OWNERS: simplify workflow/ci owners#412688
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Jun 2, 2025
Merged
Conversation
The current setup causes the Security team and the other owners of .github/workflows to **not** be pinged for the check-format/codeowners-v2/nixpkgs-vet workflows. This was highly likely unintended when adding those additional rules, so removing them. Also, we have some owners looking after `workflows/`, but not `ci/` - and some the other way around. This doesn't make much sense to me, since both parts depend on each other very much.
github-actions
bot
added
10.rebuild-darwin: 0
philiptaron
approved these changes
May 31, 2025
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
Might be time to found a team for Nixpkgs CI. There's definitely an ad-hoc one right now. I think that means opening an issue on https://github.com/nixos/org?
zowoq
approved these changes
May 31, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-412688-to-release-24.11 origin/release-24.11
cd .worktree/backport-412688-to-release-24.11
git switch --create backport-412688-to-release-24.11
git cherry-pick -x b98e7bb95a1e66d951a9c517cadb151694358bad |
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
1 task
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-24.11
git worktree add -d .worktree/backport-412688-to-release-24.11 origin/release-24.11
cd .worktree/backport-412688-to-release-24.11
git switch --create backport-412688-to-release-24.11
git cherry-pick -x b98e7bb95a1e66d951a9c517cadb151694358bad |
Contributor
|
Git push to origin failed for release-25.05 with exitcode 1 |
This was referenced Jun 13, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current setup causes the Security team and the other owners of .github/workflows to not be pinged for the
check-format/codeowners-v2/nixpkgs-vet workflows. This was highly likely unintended when adding those additional rules, so removing them.
Also, we have some owners looking after
workflows/, but notci/- and some the other way around. This doesn't make much sense to me, since both parts depend on each other very much. But, I might be missing something, so maybe some of that was on purpose.There are changes for:
ci/before.workflows/before.Please speak up if you're not OK with these changes. Of course, you are also free to comment if you're good with them ;)
Things done
Add a 👍 reaction to pull requests you find important.