llvm_{12,13,14,15}: fix build with Python 3.13#412548
Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom Jun 1, 2025
Merged
llvm_{12,13,14,15}: fix build with Python 3.13#412548mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt merged 1 commit intoNixOS:staging-nextfrom
Conversation
github-actions
bot
added
the
6.topic: llvm/clang
nix-owners
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
Python 3.13 removed the "pipes" module, which LLVM used through v16. So we need a patch. It's only used once though! A similar patch was used by Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/llvm15/-/blob/main/nopipes.diff?ref_type=heads
mdaniels5757
force-pushed
the
fix-llvm-builds
branch
from
fe538de to
7881614
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
Member
Author
|
This currently builds on GitHub Actions (for llvm_{12,13,14,15}) on x86_64-linux, aarch64-linux, and aarch64-darwin, but NOT x86_64-darwin, due to some (seemingly flakey?) libuv test failures. Trying to rebuild now. |
Member
|
Looks fine. An alternative might be just disabling the tests for older LLVM versions and not needing a patch. Interested in the thoughts of my co-maintainers. |
Member
Author
|
Finally done building: builds of llvm_12, llvm_13, llvm_14, and llvm_15 succeed on all supported platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.13 removed the "pipes" module, which LLVM used through v16.
So we need a patch. It's only used once though!
A similar patch was used by Arch: https://gitlab.archlinux.org/archlinux/packaging/packages/llvm15/-/blob/main/nopipes.diff?ref_type=heads
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.