Skip to content

Remove gtk2 from gnome3 attrset#41209

Merged
orivej merged 3 commits intoNixOS:masterfrom
jtojnar:gnome-no-gtk2
May 29, 2018
Merged

Remove gtk2 from gnome3 attrset#41209
orivej merged 3 commits intoNixOS:masterfrom
jtojnar:gnome-no-gtk2

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented May 29, 2018 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 29, 2018
@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 29, 2018

Success on x86_64-linux (full log)

Attempted: signal-desktop

Partial log (click to expand)

these derivations will be built:
  /nix/store/6l5bsvwdlydj88nhbxlhz7hvvj5n8da2-signal-desktop-1.11.0.drv
building '/nix/store/6l5bsvwdlydj88nhbxlhz7hvvj5n8da2-signal-desktop-1.11.0.drv'...
unpacking sources
installing
/nix/store/4vak9vccj9lf7lvxvq08ff6kfnrammda-signal-desktop-1.11.0

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 29, 2018

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented May 29, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: signal-desktop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@orivej orivej merged commit 59f86ab into NixOS:master May 29, 2018
@jtojnar jtojnar deleted the gnome-no-gtk2 branch May 29, 2018 13:45
@GrahamcOfBorg GrahamcOfBorg removed the 6.topic: GNOME GNOME desktop environment and its underlying platform label May 29, 2018
@jtojnar jtojnar mentioned this pull request May 29, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtojnar @GrahamcOfBorg @orivej