typora: gnome2 cleanup#41167
Merged
xeji merged 1 commit intoNixOS:masterfrom May 29, 2018
worldofpeace:patch-1
Merged
Conversation
GrahamcOfBorg
added
10.rebuild-darwin: 0
Member
|
Same here. Next time, it is fine to create a single pull request for a single operation like this. The commits are the thing that should always be separate. |
Contributor
Author
|
@jtojnar Lol, I realized that before it was too late. The pr would have been like: 'tree-wide: gnome2 cleanup' correct? I suppose I will leave the current open pr's as is or should I transubstantiate? |
Member
|
Let's leave it like it is. |
orivej
added a commit
that referenced
this pull request
May 30, 2018
* master: (30 commits) bitlbee: fix build git: 2.17.0 -> 2.17.1 sc-controller: 0.4.2 -> 0.4.3 zeroc-ice: fix parallel building pythonPackages.bsddb3: fix build after 0fd461d haskellPackages.hlibgit2: fix build after #28029 gdk-pixbuf: patch library rpath references on darwin virtualbox: fix build after #28029 GHCJS darwin fixes (#41120) neovim-remote: 1.8.6 -> 2.0.5 messenger-for-desktop: remove (#41224) typora: gnome2 cleanup (#41167) discord: gnome2 cleanup (#41174) skypeforlinux: gnome2 cleanup (#41176) wire-desktop: gnome2 cleanup (#41155) hyper: gnome2 cleanup (#41170) drone: 0.5 -> 0.8.5 (#41200) racket: use proper uname, allow for unix sockets kytea: fix build after #28029 yoda: fix build after #28029 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Removed/updated gnome2 references (Part of #39976).
Also git indoctrination stayed me from doing this in #41125
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)