versionCheckHook: add versionCheckKeepEnvironment parameter#411609
Merged
drupol merged 5 commits intoNixOS:stagingfrom Jun 2, 2025
Merged
versionCheckHook: add versionCheckKeepEnvironment parameter#411609drupol merged 5 commits intoNixOS:stagingfrom
versionCheckKeepEnvironment parameter#411609drupol merged 5 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
8.has: documentation
13 tasks
github-actions
bot
added
10.rebuild-darwin: 5001+
Defelo
force-pushed
the
push-oovqxlxzwltw
branch
2 times, most recently
from
044f8a9 to
81ac87e
Compare
Cameo007
approved these changes
May 28, 2025
Cameo007
reviewed
May 28, 2025
wcarlsen
approved these changes
May 30, 2025
Contributor
wcarlsen
left a comment
wcarlsen
left a comment
There was a problem hiding this comment.
I can successfully build ec2-instance-selector too, so all good from me.
drupol
reviewed
May 30, 2025
13 tasks
This replaces the `versionCheckDontIgnoreEnvironment` parameter. Keeping all environment variables is still possible by using `versionCheckKeepEnvironment = "*";`.
eihqnh
approved these changes
Jun 2, 2025
13 tasks
13 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows specifying a list of environment variables to pass to the version command. In contrast to
versionCheckDontIgnoreEnvironment(added in #403971)--ignore-environmentis still used and only the specified environment variables are passed to the command.cc @drupol @piotrkwiecinski
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.