Skip to content

perlPackages.IOTty: Fix RiscV cross-compilation#411195

Merged
onny merged 2 commits intoNixOS:stagingfrom
onny:iotty-update
May 31, 2025
Merged

perlPackages.IOTty: Fix RiscV cross-compilation#411195
onny merged 2 commits intoNixOS:stagingfrom
onny:iotty-update

Conversation

@onny
Copy link
Contributor

@onny onny commented May 26, 2025 •
edited
Loading

Fixes #142122

Tested using

nix build .#pkgsCross.riscv64.perl540Packages.IOTty

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested review from marcusramberg, stigtsp and zakame May 26, 2025 18:40
@github-actions github-actions bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 26, 2025
@nix-owners nix-owners bot requested review from de11n, invokes-su and qbit May 26, 2025 18:44
@onny onny added the 6.topic: riscv64 RISC-V is an open standard instruction set architecture label May 28, 2025
@onny onny changed the base branch from master to staging May 28, 2025 05:43
@nixpkgs-ci nixpkgs-ci bot closed this May 28, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this May 28, 2025
@onny onny requested a review from Ma27 May 28, 2025 05:43
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label May 28, 2025
@onny onny changed the title perlPackages.IOTty: 0.17 -> 0.20 perlPackages.IOTty: Fix RiscV cross-compilation May 28, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 28, 2025
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label May 28, 2025
@onny onny requested a review from happysalada May 29, 2025 09:10
@happysalada
Copy link
Contributor

happysalada commented May 29, 2025

The change looks good, im not very keen on merging myself since this seems to impact 1000+ rebuilds

@onny onny requested a review from MatthewCroughan May 30, 2025 06:30
@onny onny merged commit e9ee6a7 into NixOS:staging May 31, 2025
19 of 20 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 31, 2025

Backport failed for release-25.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-25.05
git worktree add -d .worktree/backport-411195-to-release-25.05 origin/release-25.05
cd .worktree/backport-411195-to-release-25.05
git switch --create backport-411195-to-release-25.05
git cherry-pick -x bd69f7fe9807754c696ade4a0b66bd42cec0eef5 a6c6250c61b984bcdade56ed2a63c60d8ca232e5

@onny onny mentioned this pull request Jun 2, 2025
Merged
13 tasks
@vcunat
Copy link
Member

vcunat commented Jun 20, 2025

For me that build is still failing.

       > xconfig.h:114:3: error: invalid preprocessing directive #HAS_FDOPENDIR
       >   114 | # HAS_FDOPENDIR         /**/
       >       |   ^~~~~~~~~~~~~

@misuzu
Copy link
Contributor

misuzu commented Jun 20, 2025

For me that build is still failing.

See #412233 (comment)

@mdaniels5757 mdaniels5757 added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@happysalada happysalada happysalada approved these changes

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

@stigtsp stigtsp Awaiting requested review from stigtsp

@zakame zakame Awaiting requested review from zakame

@qbit qbit Awaiting requested review from qbit

@invokes-su invokes-su Awaiting requested review from invokes-su

@de11n de11n Awaiting requested review from de11n

@Ma27 Ma27 Awaiting requested review from Ma27

@MatthewCroughan MatthewCroughan Awaiting requested review from MatthewCroughan

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: riscv64 RISC-V is an open standard instruction set architecture 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

perl534Packages.IOTty doesn't cross-compile

5 participants

@onny @happysalada @vcunat @misuzu @mdaniels5757