Skip to content

gcc15: update patches for 15 version#411025

Merged
vcunat merged 1 commit intoNixOS:masterfrom
trofi:gcc15-update-patches
May 28, 2025
Merged

gcc15: update patches for 15 version#411025
vcunat merged 1 commit intoNixOS:masterfrom
trofi:gcc15-update-patches

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented May 26, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@trofi trofi mentioned this pull request May 26, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 26, 2025
@trofi
Copy link
Contributor Author

trofi commented May 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 411025
Commit: 67cc3aa69a3b411a4501eb46c67ad38a1e6d35b4

x86_64-linux

✅ 34 packages built:
  • fastStdenv
  • gcc15
  • gcc15.info
  • gcc15.man
  • gcc15Stdenv
  • gccgo15
  • gccgo15.info
  • gccgo15.man
  • gfortran15
  • gfortran15.info
  • gfortran15.man
  • gnat15
  • gnat15.info
  • gnat15.man
  • gnat15Packages.gnatcoll-core
  • gnat15Packages.gnatcoll-cpp
  • gnat15Packages.gnatcoll-db2ada
  • gnat15Packages.gnatcoll-gmp
  • gnat15Packages.gnatcoll-iconv
  • gnat15Packages.gnatcoll-lzma
  • gnat15Packages.gnatcoll-omp
  • gnat15Packages.gnatcoll-postgres
  • gnat15Packages.gnatcoll-python3
  • gnat15Packages.gnatcoll-readline
  • gnat15Packages.gnatcoll-sql
  • gnat15Packages.gnatcoll-sqlite
  • gnat15Packages.gnatcoll-syslog
  • gnat15Packages.gnatcoll-xref
  • gnat15Packages.gnatcoll-zlib
  • gnat15Packages.gnatinspect
  • gnat15Packages.gpr2
  • gnat15Packages.gprbuild
  • gnat15Packages.gprbuild-boot
  • gnat15Packages.xmlada

@vcunat
Copy link
Member

vcunat commented May 27, 2025

gcc15 on aarch64-darwin still fails to build (on both ofBorg and my local test). No idea about x86_64-darwin.

So maybe we could merge just those four lines for now and leave darwin as a draft PR until it works?

@trofi
Copy link
Contributor Author

trofi commented May 27, 2025

gcc15 on aarch64-darwin still fails to build (on both ofBorg and my local test). No idea about x86_64-darwin.

Ugh, I'll need a darwin box (or a darwin team) to look in more detail :(

So maybe we could merge just those four lines for now and leave darwin as a draft PR until it works?

Sounds good. Moved 4 lines out to a separate PR: #411542

@mkannwischer mkannwischer mentioned this pull request May 28, 2025
Closed
@vcunat vcunat added the 6.topic: darwin Running or building packages on Darwin label May 28, 2025
@xokdvium
Copy link
Contributor

xokdvium commented May 28, 2025

No idea about x86_64-darwin.

FWIW x86_64-darwin does build with these patches applied.

@vcunat vcunat merged commit fda811e into NixOS:master May 28, 2025
20 of 21 checks passed
@vcunat
Copy link
Member

vcunat commented May 28, 2025

OK, makes sense to merge then.

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 28, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request May 28, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 28, 2025
@vcunat
Copy link
Member

vcunat commented May 29, 2025

Hydra confirms that this fixes gcc15 and gfortran15 for x86_64-darwin:
https://hydra.nixos.org/eval/1815664?filter=15.x86_64-darwin#tabs-now-succeed
(gnat fails for x86_64-darwin for all versions and other gcc-derived builds seem linux-only)

@trofi trofi deleted the gcc15-update-patches branch May 29, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trofi @vcunat @xokdvium