python3Packages.typedunits: Disable fractional rounding test on aarch64#410612
Merged
drupol merged 1 commit intoNixOS:masterfrom May 28, 2025
Merged
python3Packages.typedunits: Disable fractional rounding test on aarch64#410612drupol merged 1 commit intoNixOS:masterfrom
drupol merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
the
6.topic: python
sarahec
added
the
11.by: package-maintainer
github-actions
bot
added
10.rebuild-darwin: 1-10
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hydra: https://hydra.nixos.org/build/298234353
quantumlib/TypedUnits#14 documents a failing test due to rounding error. I originally encountered this on aarch64-darwin and assumed it was darwin-specific, but it also fails on aarch64-linux.
Changed the test exclusion from
isDarwintoisAarch.ZHF: #403336
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.