doc/rl2505: move variants to 25.05#410359
Merged
RossComputerGuy merged 1 commit intoNixOS:masterfrom May 24, 2025
Merged
Conversation
github-actions
bot
added
the
8.has: documentation
13 tasks
github-actions
bot
added
10.rebuild-darwin: 1
Merged
1 task
MattSturgeon
approved these changes
May 24, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
LGTM, assuming #410362 is merged first.
As per #410362 (comment), that PR should end up with the release note in the 2505 section, so both branches have the release note in the same files.
Member
Author
|
Yeah, the plan is:
|
Contributor
Feels like that could be done as part of #410362, but either way it achieves the same result if you backport this PR 👍 |
wegank
added
the
12.approvals: 1
Aleksanaa
approved these changes
May 24, 2025
Member
Aleksanaa
left a comment
Aleksanaa
left a comment
There was a problem hiding this comment.
lgtm on description improvement
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-410359-to-release-25.05 origin/release-25.05
cd .worktree/backport-410359-to-release-25.05
git switch --create backport-410359-to-release-25.05
git cherry-pick -x bb23492d23460e00c4aff751d51ba04d2397da36 |
Member
|
Thank you! |
Member
Author
|
Huh backport failed and I didn't see an email about it. |
13 tasks
Member
Author
|
Backported in #411008 |
mdaniels5757
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.