[25.05] nixosTests.turbovnc-headless-server: Remove expected-failing test.#410005
Merged
nh2 merged 1 commit intoNixOS:release-25.05from May 24, 2025
Merged
Conversation
nh2
changed the title
github-actions
bot
added
6.topic: nixos
This was referenced May 23, 2025
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Suggesting as reviewers perhaps @wolfgangwalther @wamserma |
nh2
force-pushed
the
turbovnc-fix-test-issue-328923-nixos-25.05
branch
from
c6d5fbf to
5e0838f
Compare
github-actions
bot
added
10.rebuild-linux: 1
Contributor
|
The PR title says it backports the test fix only. The commit is only the update, though. I'm a bit confused what the goal is - only one of them? Both? |
Contributor
Author
@wolfgangwalther You're completely right, I cherry-picked the wrong of the 2 commits, thanks for spotting, will fix! |
It doesn't fail as expected anymore because `LIBGL_DRIVERS_PATH` was removed in Mesa 24.2, and apparently there's no replacement for it: NixOS#328923 Given that it was removed, and https://www.phoronix.com/news/Mesa-24.2-Modern-Interfaces and https://www.supergoodcode.com/long-road-to-DRIL/ saying that removes the problem it originally caused (also for us), this test is probably superfluous because the thing it guards against is gone. (cherry picked from commit e1a5818)
nh2
force-pushed
the
turbovnc-fix-test-issue-328923-nixos-25.05
branch
from
5e0838f to
862e9ee
Compare
github-actions
bot
added
the
6.topic: nixos
Contributor
Author
|
@wolfgangwalther Now it's right! |
github-actions
bot
added
10.rebuild-linux: 0
Contributor
Author
|
ofborg CI on x86_64-linux passed, that's good enough for the test fix backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZHF: #403336
Backport of the test-fixing commit from #410000.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.