Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
It doesn't fail as expected anymore because `LIBGL_DRIVERS_PATH` was removed in Mesa 24.2, and apparently there's no replacement for it: NixOS#328923 Given that it was removed, and https://www.phoronix.com/news/Mesa-24.2-Modern-Interfaces and https://www.supergoodcode.com/long-road-to-DRIL/ saying that removes the problem it originally caused (also for us), this test is probably superfluous because the thing it guards against is gone.
* `-DTVNC_*` flags are no longer necessary, as the comment explains. * `-DTJPEG_JAR` and `-DTJPEG_JNILIBRARY` were already removed in turbovnc 3.0beta1, commit TurboVNC/turbovnc@4d9a877 and replaced by `-DTJPEG_LIBRARY` and `-DTJPEG_INCLUDE_DIR`, but turbovnc detects libjpeg-turbo correctly automatically, with output: -- Performing Test TURBOJPEG_WORKS -- Performing Test TURBOJPEG_WORKS - Failed -- Could not link with official TurboJPEG library /var/empty/libjpeg-turbo/lib64/libturbojpeg.a. Checking whether the operating system supplies it ... -- Performing Test SYSTEM_TURBOJPEG_WORKS -- Performing Test SYSTEM_TURBOJPEG_WORKS - Success
3 tasks
Contributor
Author
Fixed in the pushed commit. |
github-actions
bot
added
the
6.topic: nixos
13 tasks
Contributor
Author
|
25.05 backport: #410005 |
Contributor
Author
|
I've tested it, works well for running e.g. Chromium. Please merge when CI is green. |
Contributor
Author
|
Suggesting as reviewers perhaps @wolfgangwalther @wamserma |
ruben-benaco
approved these changes
May 23, 2025
ruben-benaco
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See mainly https://github.com/TurboVNC/turbovnc/releases/tag/3.2beta1 for where most changes for 3.2 are listed, and my commit message.
NixOS VM tests currently fail, already before this upgrade.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.