Skip to content

python3Packages.django-google-analytics-app: cleanup#409963

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
sarahec:cleanup-django-google-analytics-app
May 29, 2025
Merged

python3Packages.django-google-analytics-app: cleanup#409963
JohnRTitor merged 1 commit intoNixOS:masterfrom
sarahec:cleanup-django-google-analytics-app

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 22, 2025

Cleanup: modernize build, fix 'with lib'.

Tracking: #407693

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Cleanup: modernize build, fix 'with lib'.
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 23, 2025
@nix-owners nix-owners bot requested a review from DerDennisOP May 23, 2025 00:00
@sarahec sarahec requested a review from fabaff May 23, 2025 00:17
@sarahec
Copy link
Contributor Author

sarahec commented May 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 409963
Commit: 0f1b754a14401196a4e5946d7afccc6a611d7d19


x86_64-linux

✅ 4 packages built:
  • python312Packages.django-google-analytics-app
  • python312Packages.django-google-analytics-app.dist
  • python313Packages.django-google-analytics-app
  • python313Packages.django-google-analytics-app.dist

@sarahec
Copy link
Contributor Author

sarahec commented May 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 409963


aarch64-darwin

✅ 4 packages built:
  • python312Packages.django-google-analytics-app
  • python312Packages.django-google-analytics-app.dist
  • python313Packages.django-google-analytics-app
  • python313Packages.django-google-analytics-app.dist

Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sarahec sarahec added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 29, 2025
@JohnRTitor JohnRTitor merged commit 751159c into NixOS:master May 29, 2025
22 of 23 checks passed
@sarahec sarahec deleted the cleanup-django-google-analytics-app branch May 29, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants