Skip to content

python3Packages.googlemaps: cleanup#409959

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
sarahec:cleanup-googlemaps
May 29, 2025
Merged

python3Packages.googlemaps: cleanup#409959
JohnRTitor merged 1 commit intoNixOS:masterfrom
sarahec:cleanup-googlemaps

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 22, 2025

  1. Removed pythonOlder and fixed with lib
  2. Modernized build

No version update needed.

Tracking: #407693

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 22, 2025
@sarahec sarahec requested a review from fabaff May 23, 2025 00:17
@fabaff
Copy link
Member

fabaff commented May 23, 2025

Looks like that the two commits could be one.

@sarahec sarahec force-pushed the cleanup-googlemaps branch from 0eb4e03 to 7ee64db Compare May 23, 2025 21:28
@sarahec
Copy link
Contributor Author

sarahec commented May 23, 2025

Looks like that the two commits could be one.

Indeed. Fixed.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 23, 2025
@nix-owners nix-owners bot requested a review from Scriptkiddi May 23, 2025 21:35
@sarahec
Copy link
Contributor Author

sarahec commented May 29, 2025

@fabaff review, please?

@sarahec sarahec force-pushed the cleanup-googlemaps branch from 7ee64db to 49c7b25 Compare May 29, 2025 00:31
Remove pythonOlder, fix with lib
@sarahec sarahec force-pushed the cleanup-googlemaps branch from 49c7b25 to ced6ee2 Compare May 29, 2025 00:32
@JohnRTitor JohnRTitor merged commit 25251cb into NixOS:master May 29, 2025
16 of 18 checks passed
@sarahec
Copy link
Contributor Author

sarahec commented May 29, 2025

@JohnRTitor thanks

@sarahec sarahec deleted the cleanup-googlemaps branch May 29, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants