Skip to content

python3Packages.google-cloud-netapp: refactor#409951

Merged
fabaff merged 1 commit intoNixOS:masterfrom
sarahec:refactor-google-cloud-netapp
May 27, 2025
Merged

python3Packages.google-cloud-netapp: refactor#409951
fabaff merged 1 commit intoNixOS:masterfrom
sarahec:refactor-google-cloud-netapp

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 22, 2025

Build from github repo, modernize, enable tests, and add maintainer

Tracking: #407693

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sarahec sarahec requested a review from fabaff May 22, 2025 23:20
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 22, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 22, 2025
@sarahec sarahec force-pushed the refactor-google-cloud-netapp branch from a8eaab1 to daa6c84 Compare May 23, 2025 20:10
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label May 23, 2025
@nix-owners nix-owners bot requested review from mweinelt and natsukium May 23, 2025 20:12
@sarahec sarahec force-pushed the refactor-google-cloud-netapp branch from daa6c84 to fc2414c Compare May 23, 2025 20:18
@sarahec sarahec marked this pull request as draft May 23, 2025 20:20
@sarahec sarahec marked this pull request as ready for review May 23, 2025 20:29
Build from github repo, modernize, enable tests, and add maintainer
@sarahec sarahec changed the base branch from python-updates to master May 23, 2025 20:59
@sarahec sarahec force-pushed the refactor-google-cloud-netapp branch from fc2414c to 6a3bfcd Compare May 23, 2025 20:59
@nixpkgs-ci nixpkgs-ci bot closed this May 23, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this May 23, 2025
@sarahec sarahec removed the 8.has: documentation This PR adds or changes documentation label May 24, 2025
@fabaff
Copy link
Member

fabaff commented May 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 409951


x86_64-linux

✅ 4 packages built:
  • python312Packages.google-cloud-netapp
  • python312Packages.google-cloud-netapp.dist
  • python313Packages.google-cloud-netapp
  • python313Packages.google-cloud-netapp.dist

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me.

@fabaff fabaff merged commit 0b8b7e9 into NixOS:master May 27, 2025
36 of 37 checks passed
@sarahec sarahec deleted the refactor-google-cloud-netapp branch May 27, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants