python3Packages.google-cloud-kms: refactor#409933
Merged
dotlambda merged 1 commit intoNixOS:masterfrom Jun 1, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: python
github-actions
bot
added
10.rebuild-darwin: 101-500
sarahec
force-pushed
the
google-cloud-kms-refactor
branch
from
b5197d0 to
73206de
Compare
sarahec
force-pushed
the
google-cloud-kms-refactor
branch
from
73206de to
d0e6e3a
Compare
sarahec
force-pushed
the
google-cloud-kms-refactor
branch
from
d0e6e3a to
e4dfe6d
Compare
dotlambda
reviewed
May 29, 2025
Member
dotlambda
left a comment
dotlambda
left a comment
There was a problem hiding this comment.
No need to target staging. I can run nixpkgs-review for you.
Comment on lines
57
to
59
Member
There was a problem hiding this comment.
Is there any advantage over
Suggested change
| passthru.updateScript = nix-update-script { | |
| extraArgs = [ | |
| "--version-regex" | |
| "google-cloud-kms-v[0-9.]+)" | |
| ]; | |
| }; | |
| passthru.updateScript = gitUpdater { | |
| rev-prefix = "google-cloud-kms-v"; | |
| }; |
?
Contributor
Author
There was a problem hiding this comment.
gitUpdater will grab the wrong update from monorepos with multiple components in the release list. The updater gets a list of tags, strips off the prefix then sorts and grabs the first. It's not filtering by prefix.
Having been bitten by this multiple times (e.g. on langchain and langgraph), I've found the only reliable fix is the one I'm using. nix-update-script is applying the regex as a filter before sorting.
Member
There was a problem hiding this comment.
It does pick the correct tag if you specify rev-prefix.
Contributor
Author
There was a problem hiding this comment.
Aha, I misread the code.
Contributor
Author
There was a problem hiding this comment.
Updated. Now to go hunt through my other open PRs.
Contributor
Author
Thank you. To confirm, I should put this on |
Member
Yes |
sarahec
force-pushed
the
google-cloud-kms-refactor
branch
2 times, most recently
from
2218c12 to
09b8a32
Compare
Use Github source, enable update script, add maintainer.
sarahec
force-pushed
the
google-cloud-kms-refactor
branch
from
09b8a32 to
91afc8d
Compare
Contributor
Author
Changes all applied, rebased to |
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Github source, enable update script, add maintainer.
Tracking: #407693
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.