Skip to content

python3Packages.google-search-results: refactor#409919

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
sarahec:refactor-google-search-results
May 26, 2025
Merged

python3Packages.google-search-results: refactor#409919
Aleksanaa merged 1 commit intoNixOS:masterfrom
sarahec:refactor-google-search-results

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 22, 2025

  1. Build from Github instead of PyPi
  2. Modernize: remove pythonOlder, with lib, fix build-system, etc.

Tracking: #407693

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 22, 2025
@nix-owners nix-owners bot requested a review from natsukium May 22, 2025 22:12
@sarahec sarahec force-pushed the refactor-google-search-results branch from 4fd13dd to 4b5741d Compare May 23, 2025 20:36
@sarahec sarahec requested a review from fabaff May 23, 2025 20:36
@sarahec sarahec changed the base branch from python-updates to master May 23, 2025 20:49
@sarahec sarahec force-pushed the refactor-google-search-results branch from 4b5741d to 0475645 Compare May 23, 2025 20:49
@nixpkgs-ci nixpkgs-ci bot closed this May 23, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this May 23, 2025
@Aleksanaa Aleksanaa merged commit 276cf75 into NixOS:master May 26, 2025
36 of 37 checks passed
@sarahec sarahec deleted the refactor-google-search-results branch May 27, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants