Skip to content

doc/rl2511: update allowVariants entry#409484

Merged
RossComputerGuy merged 1 commit intoNixOS:masterfrom
RossComputerGuy:feat/update-docs-allowvariants
May 22, 2025
Merged

doc/rl2511: update allowVariants entry#409484
RossComputerGuy merged 1 commit intoNixOS:masterfrom
RossComputerGuy:feat/update-docs-allowvariants

Conversation

@RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented May 21, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label May 21, 2025
@RossComputerGuy RossComputerGuy mentioned this pull request May 21, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 21, 2025
@Ericson2314
Copy link
Member

Ericson2314 commented May 21, 2025 •
edited
Loading

Wait is 25.05 getting this flag? I would like it too, so we can start opting out of variants on stable ASAP.

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented May 21, 2025

Wait is 25.05 getting this flag? I would like it too, so we can start opting out of variants on stable ASAP.

I don't think so? We would have to move the release notes and backport things.

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 22, 2025
@RossComputerGuy RossComputerGuy merged commit fe51d34 into NixOS:master May 22, 2025
27 of 28 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/update-docs-allowvariants branch May 22, 2025 23:55
Aleksanaa
Aleksanaa reviewed May 23, 2025
View reviewed changes
doc/release-notes/rl-2511.section.md
<!-- To avoid merge conflicts, consider adding your item at an arbitrary place in the list instead. -->

- Added `allowVariants` to gate availability of package sets like `pkgsLLVM`, `pkgsMusl`, `pkgsZig`, etc.
- Added `allowVariants` to gate availability of package sets like `pkgsLLVM`, `pkgsMusl`, `pkgsZig`, etc. This option will be removed in a future release.
Copy link
Member

@Aleksanaa Aleksanaa May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make this sentence less confusing, like why we added it, how this might affect usage, and why it might be removed in the future

Copy link
Member Author

@RossComputerGuy RossComputerGuy May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, will clean it up when we move it to 24.11 since @Ericson2314 suggested that.

Copy link
Member Author

@RossComputerGuy RossComputerGuy May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#410359

@Ericson2314
Copy link
Member

Ericson2314 commented May 23, 2025

I would like to backport this. It is not a breaking change so there should be no problem with that?

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented May 23, 2025

We would have to move around the release notes a bit if that's fine.

@Ericson2314
Copy link
Member

Ericson2314 commented May 23, 2025

That's fine with me!

@RossComputerGuy
Copy link
Member Author

RossComputerGuy commented May 24, 2025

#410359

@RossComputerGuy RossComputerGuy mentioned this pull request May 24, 2025
Merged
13 tasks
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 24, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request May 24, 2025
Merged
1 task
@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 24, 2025
@RossComputerGuy RossComputerGuy mentioned this pull request May 26, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@MattSturgeon MattSturgeon MattSturgeon approved these changes

Assignees

No one assigned

Labels

8.has: documentation This PR adds or changes documentation 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RossComputerGuy @Ericson2314 @MattSturgeon @Aleksanaa @wegank