nltk-data: make searchable, add all downloadables#409482
Merged
happysalada merged 8 commits intoNixOS:masterfrom May 22, 2025
Merged
nltk-data: make searchable, add all downloadables#409482happysalada merged 8 commits intoNixOS:masterfrom
happysalada merged 8 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: python
There are no scripts in the `package` folder, only datasets, models, etc.
nltk-data is an attribute set, which leads to nixos search omitting it. Wrapping it in `recurseIntoAttrs` remedies this.
github-actions
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
|
nix-owners
bot
requested review from
anoadragon453,
antonmosich,
happysalada,
litchipi,
mbalatsko and
yzx9
…perceptron-tagger
…ged-perceptron-tagger-eng
antonmosich
approved these changes
May 21, 2025
Contributor
antonmosich
left a comment
antonmosich
left a comment
There was a problem hiding this comment.
Looks good to me. It feels a bit odd to have all the makeCorpus etc. calls done manually instead of using something map-ish, but it isn't obvious to me how to do that in a concise way.
Contributor
|
Nice improvement ! And welcome as a maintainer ! |
Member
|
This broke alias eval, revert in #409843. |
7 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searching for nltk-data returns no results.
Applying a similar fix as done in #402602 will hopefully fix this.
Additional QoL fixes include not attempting to patch files where there is nothing to patch and adding all downloadables that are in the
nltk_datarepository to the attribute set.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.