vmtools.diskImageFuns: drop EOL distributions#409108
vmtools.diskImageFuns: drop EOL distributions#409108philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
These went back as far as 2011, and none of them are in active security support. We shouldn’t ship them without a warning and I doubt anyone is using them with a recent Nixpkgs.
emilazy
added
the
1.severity: security
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
I have a little sticky note on my desk (which sadly has collected a bit of dust) to update all of these to recent versions. This is a fine standin.
I suspect you can yank further and remove now-unused helpers, etc.
I do have one request: can you leave a breadcrumb comment referring to this PR so that there's a pathway for the person who comes along and tries to resurrect things?
github-actions
bot
added
10.rebuild-darwin: 0
Eh, maybe they’ll be useful in future. I mostly wanted to get rid of the last users of some of these mirrors. I am not sure that the CentOS stuff will be useful to anyone in future though since that distribution is dead. The Ubuntu and Debian ones follow the same pattern as the versions that remain. So I’m not sure what pointer you want to see left here. |
|
I was imagining a |
3 participants
These went back as far as 2011, and none of them are in active security support. We shouldn’t ship them without a warning and I doubt anyone is using them with a recent Nixpkgs.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.