Merged
Conversation
13 tasks
Member
|
ack for backport to 25.05 |
Unused, unmaintained image processing library stuck on an outdated version from 2016 and untouched outside of treewides/ZHF since that bump. Per <https://github.com/ImageMagick/libfpx/blob/9b547af9651c7147ecebbda567543cc802c8135c/ChangeLog>, this version has known vulnerabilities. The source tarball has also vanished from all of the mirrors.
878b4ea to
ced8a6a
Compare
13 tasks
philiptaron
approved these changes
May 20, 2025
Contributor
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-25.05
git worktree add -d .worktree/backport-409063-to-release-25.05 origin/release-25.05
cd .worktree/backport-409063-to-release-25.05
git switch --create backport-409063-to-release-25.05
git cherry-pick -x ced8a6aef6f2cab09a8d7650d4ee333114d11bcb |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unused, unmaintained image processing library stuck on an outdated version from 2016 and untouched outside of treewides/ZHF since that bump. Per https://github.com/ImageMagick/libfpx/blob/9b547af9651c7147ecebbda567543cc802c8135c/ChangeLog, this version has known vulnerabilities. The source tarball has also vanished from all of the mirrors.
cc @leona-ya I’ll mark this as vulnerable on 24.11 but I’d like to backport this to 25.05 so we don’t ship the release with this thing.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.