Skip to content

stalwart-mail: use system jemalloc#409024

Merged
happysalada merged 1 commit intoNixOS:masterfrom
yuyuyureka:stelwart-16k
May 21, 2025
Merged

stalwart-mail: use system jemalloc#409024
happysalada merged 1 commit intoNixOS:masterfrom
yuyuyureka:stelwart-16k

Conversation

@yuyuyureka
Copy link
Contributor

fixes the package on aarch64 16k-pagesize systems

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fixes the package on aarch64 16k-pagesize systems
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2025
@happysalada
Copy link
Contributor

Happy to leave this open for 24h to leave others the chance to have a look just in case

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 20, 2025
Copy link
Member

@oddlama oddlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Pandapip1
Copy link
Member

Could you add a nixos test for this behavior?

@yuyuyureka
Copy link
Contributor Author

Could you add a nixos test for this behavior?

As the NixOS Tests run with a 4k pagesize kernel, I don't think it is possible to test the behavior within a NixOS test.

@happysalada happysalada merged commit 3f4996f into NixOS:master May 21, 2025
23 of 24 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 21, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 21, 2025
@happysalada
Copy link
Contributor

Given that the change is relatively simple , i went ahead and merged. If anyone feels an item hasnt been properly addressed, i would say we can continue discussing here and/or open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants