Skip to content

nixos/orca: Make available to gdm greeter#408899

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:orca-gdm
May 20, 2025
Merged

nixos/orca: Make available to gdm greeter#408899
jtojnar merged 1 commit intoNixOS:masterfrom
jtojnar:orca-gdm

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented May 20, 2025

Without this, the greeter is unable to see orca program on PATH and so ${gdm}/share/gdm/greeter/autostart/orca-autostart.desktop will fail to start orca. As a result, screen reader would not work on the login screen.

Supersedes: #408898

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested that orca works in GDM.
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 20, 2025
@jtojnar jtojnar mentioned this pull request May 20, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2025
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Without this, the greeter is unable to see `orca` program on `PATH`
and so `${gdm}/share/gdm/greeter/autostart/orca-autostart.desktop`
will fail to start it. As a result, screen reader would not work
on the login screen.
@jtojnar jtojnar added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: accessibility Make things in Nixpkgs usable by as many people of varying ability as possible backport release-25.05 labels May 20, 2025
@jtojnar jtojnar merged commit 9af27f1 into NixOS:master May 20, 2025
21 of 24 checks passed
@jtojnar jtojnar deleted the orca-gdm branch May 20, 2025 18:08
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 20, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: accessibility Make things in Nixpkgs usable by as many people of varying ability as possible 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants