Closed
Conversation
Merged
For some reason, the greeter is unable to pick up orca from PATH so `TryExec` will fail. As a result, screen reader does not work on the login screen. It would be nicer to adjust the environment variable propagation/filtering so that people allergic to “bloat” can still disable installing orca but I currently do not have time to debug that.
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
Member
Author
|
Oh, I just recalled that we are setting path of display-manager service so we can just do that #408899 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #408899
For some reason, the greeter is unable to pick up orca from PATH
so
TryExecwill fail. As a result, screen reader does not workon the login screen.
It would be nicer to adjust the environment variable
propagation/filtering so that people allergic to “bloat”
can still disable installing orca but I currently
do not have time to debug that.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.