python3Packages.google-photos-library-api: fix failing tests on Darwin #407800
Merged
phaer merged 1 commit intoNixOS:masterfrom May 27, 2025
Merged
python3Packages.google-photos-library-api: fix failing tests on Darwin #407800phaer merged 1 commit intoNixOS:masterfrom
phaer merged 1 commit intoNixOS:masterfrom
Conversation
dotlambda
reviewed
May 17, 2025
pkgs/development/python-modules/google-photos-library-api/default.nix
Outdated
Show resolved
Hide resolved
d7226ff to
fd78667
Compare
Aleksanaa
approved these changes
May 18, 2025
fd78667 to
d6ddf92
Compare
d6ddf92 to
fbc629c
Compare
fbc629c to
1df15b9
Compare
1df15b9 to
0c2179f
Compare
Needs _darwinEnableLocalNetworking
0c2179f to
7a51e04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four tests fail when built on Darwin with
sandbox=relaxed.Disabled these tests only for Darwin.Enabling local networking fixes this.Tracking: #407693'
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.