Skip to content

python3Packages.google-photos-library-api: fix failing tests on Darwin #407800

Merged
phaer merged 1 commit intoNixOS:masterfrom
sarahec:google-photos-lib-zhf
May 27, 2025
Merged

python3Packages.google-photos-library-api: fix failing tests on Darwin #407800
phaer merged 1 commit intoNixOS:masterfrom
sarahec:google-photos-lib-zhf

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 17, 2025

Four tests fail when built on Darwin with sandbox=relaxed. Disabled these tests only for Darwin. Enabling local networking fixes this.

Tracking: #407693'

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 17, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 17, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2025
@nix-owners nix-owners bot requested a review from dotlambda May 17, 2025 03:00
@sarahec sarahec force-pushed the google-photos-lib-zhf branch 3 times, most recently from d7226ff to fd78667 Compare May 17, 2025 18:47
@sarahec sarahec changed the title python3Packages.google-photos-library-api: disable failing tests on Darwin python3Packages.google-photos-library-api: fix failing tests on Darwin May 17, 2025
@github-actions github-actions bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 17, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 18, 2025
@sarahec sarahec force-pushed the google-photos-lib-zhf branch from fd78667 to d6ddf92 Compare May 20, 2025 19:22
@sarahec sarahec force-pushed the google-photos-lib-zhf branch from d6ddf92 to fbc629c Compare May 21, 2025 00:08
@sarahec sarahec force-pushed the google-photos-lib-zhf branch from fbc629c to 1df15b9 Compare May 21, 2025 19:57
@sarahec sarahec changed the base branch from master to python-updates May 21, 2025 19:58
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 21, 2025
@sarahec sarahec force-pushed the google-photos-lib-zhf branch from 1df15b9 to 0c2179f Compare May 22, 2025 22:10
@sarahec sarahec changed the base branch from python-updates to master May 23, 2025 20:45
@sarahec sarahec force-pushed the google-photos-lib-zhf branch from 0c2179f to 7a51e04 Compare May 23, 2025 20:45
@nixpkgs-ci nixpkgs-ci bot closed this May 23, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this May 23, 2025
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 24, 2025
@sarahec sarahec requested a review from dotlambda May 25, 2025 22:37
@phaer phaer merged commit 930c260 into NixOS:master May 27, 2025
37 of 38 checks passed
@sarahec sarahec deleted the google-photos-lib-zhf branch May 28, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants