llvmPackages: llvmPackages_19 -> llvmPackages_21 by RossComputerGuy · Pull Request #407738 · NixOS/nixpkgs

RossComputerGuy · 2025-05-16T21:44:06Z

Things done

Bump the global LLVM version. Tested builds:

Add a 👍 reaction to pull requests you find important.

winterqt

~~Please fix eval.~~ Someone else broke it, disregard.

RossComputerGuy · 2025-05-22T17:58:51Z

error: Alias nltk-data is still in all-packages.nix

I have no idea why this is happening and I don't think it's related to anything I changed. It worked before I rebased to resolve conflicts.

winterqt · 2025-05-22T17:59:45Z

~~Indeed — have retriggered a test merge and eval. If that doesn’t fix it I’ll go fix it myself, I just imagine it was fixed by now.~~

Fixed in #409843.

kilyanni · 2025-08-25T14:52:15Z

~~For llvmPackages_21.libclc, I believe the gnu-install-dirs patch should be updated as the header install was removed: llvm/llvm-project@a2b0576.~~

~~With this commit applied on top of this branch it builds properly (with SPIRV manually updated to nightly to fix broken spirv-llvm-translator)~~

Resolved in #436446

emilazy · 2025-09-05T19:23:09Z

pkgs/top-level/all-packages.nix

These should presumably be dropped?

Because it wasn’t there in the previous version, and it pins an old version of LLVM, and the commit description is “rust: track latest LLVM to simplify version bumps”?

That's because rust has been using LLVM 20, does it support 21?

I’m confused – if your intent wasn’t to have Rust track the latest LLVM for LLVM 21, then why did you make a commit with the title “rust: track latest LLVM to simplify version bumps” that made Rust track the latest LLVM, in the LLVM 21 bump PR?

These pins appeared at some point during a rebase. I believe Rust always supports the latest LLVM, but if we want to keep Rust pinned to LLVM 20 then we shouldn’t have a commit talking about unpinning it in an LLVM 21 bump PR that doesn’t unpin it. What makes sense to me is dropping the pins here to accomplish the goal of the commit message, but I might be misunderstanding what the intent of the commit was?

Because that commit was made when this was doing LLVM 20 at first.

Ah, okay. But then the commit nothing to do with LLVM 21 and has no functional effect now, so why is it in the LLVM 21 bump PR?

I thought that the intent of unpinning LLVM in Rust was to update Rust’s LLVM when we update the default LLVM, so pinning it because we’re updating to 21 instead doesn’t make sense to me. If we want to unpin Rust’s LLVM so that it always matches the default LLVM, then we should want Rust to start using LLVM 21 when we make that the default, right?

I'm not sure, I'm about to sleep so I can't think. Let's see what rust maintainers think. Maybe @alyssais would have a good idea?

Rust should just use our default version of LLVM.

emilazy · 2025-09-14T20:33:07Z

We’re close to landing the work I did to get this ready for merge but it needs a rebase and the Rust stuff addressing.

emilazy · 2025-09-16T03:31:37Z

Needs another rebase 😅

RossComputerGuy · 2025-09-16T03:34:37Z

Fixed, hopefully that's the last time I have to rebase this PR.

emilazy · 2025-09-16T03:52:30Z

Yeah, there’s still fixes in the pipeline but now that we have the Darwin system libc++ PR merged staging is close enough to the environment I’ve been testing things in that I feel confident merging this for the next cycle. Let’s do this.

trofi · 2025-09-19T05:30:22Z

Bisect says that cabe58b llvmPackages: llvmPackages_19 -> llvmPackages_21 broke a few packages in staging:

nixd:

$ nix build --no-link -f. nixd -L
...
nixd> llvm-config found: NO
nixd> Run-time dependency LLVM found: NO (tried config-tool)
nixd>
nixd> meson.build:34:7: ERROR: Dependency lookup for llvm with method 'cmake' failed: Dependency LLVM not found:     PACKAGE_FOUND is false

cvise:

$ nix build --no-link -f. cvise -L
...
cvise> [ 44%] Building CXX object clang_delta/CMakeFiles/clang_delta.dir/MergeBaseClass.cpp.o
cvise> In file included from /build/source/clang_delta/RemoveBaseClass.cpp:19:
cvise> /build/source/clang_delta/CommonRenameClassRewriteVisitor.h: In member function ‘bool   clang_delta_common_visitor::CommonRenameClassRewriteVisitor<T>::VisitDependentTemplateSpe cializationTypeLoc(clang::DependentTemplateSpecializationTypeLoc)’:
cvise> /build/source/clang_delta/CommonRenameClassRewriteVisitor.h:371:40: error: ‘const class clang::DependentTemplateSpecializationType’ has no member named ‘getIdentifier’
cvise>   371 |   const IdentifierInfo *IdInfo = DTST->getIdentifier();
cvise>       |                                        ^~~~~~~~~~~~~

trofi · 2025-10-06T08:36:30Z

Now that llvmPackages is at 21 in master it also broke cvise. Proposed a workaround as:

cvise: 2.11.0 -> 2.12.0 #445714

RossComputerGuy force-pushed the feat/llvm-bump branch from 590b859 to 76e297c Compare May 16, 2025 22:04

github-actions bot added the 8.has: documentation This PR adds or changes documentation label May 16, 2025

RossComputerGuy force-pushed the feat/llvm-bump branch from 76e297c to 1234428 Compare May 17, 2025 05:20

github-actions bot added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related labels May 17, 2025

RossComputerGuy changed the title ~~pkgs/top-level/all-packages.nix: use LLVM 20 for treewide LLVM~~ llvmPackages: llvmPackages_19 -> llvmPackages_20 May 17, 2025

reckenrode mentioned this pull request May 10, 2025

Tracking issue: Darwin updates for 25.11 #405893

Open

2 tasks

RossComputerGuy mentioned this pull request May 21, 2025

llvmPackages_{20,21,git}.compiler-rt: no fmv on aarch64 without libc #409265

Merged

13 tasks

RossComputerGuy force-pushed the feat/llvm-bump branch from 1234428 to 042256a Compare May 22, 2025 16:48

RossComputerGuy marked this pull request as ready for review May 22, 2025 16:48

nix-owners bot requested review from Ericson2314, Mic92, alyssais, dtzWill, figsoda, lovek323, rrbutani, sternenseemann, winterqt and zowoq May 22, 2025 16:50

winterqt previously requested changes May 22, 2025

View reviewed changes

winterqt self-requested a review May 22, 2025 17:58

nix-owners bot requested review from edolstra and fpletz May 22, 2025 19:45

RossComputerGuy force-pushed the feat/llvm-bump branch 2 times, most recently from 7eba173 to 1b44f52 Compare August 24, 2025 03:55

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 24, 2025

RossComputerGuy mentioned this pull request Aug 24, 2025

llvmPackages_{20,21}.libclc: reenable #436446

Merged

13 tasks

nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 25, 2025

RossComputerGuy force-pushed the feat/llvm-bump branch 2 times, most recently from 8435796 to 542c28d Compare September 1, 2025 02:31

nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 1, 2025

emilazy mentioned this pull request Sep 4, 2025

{intel-compute-runtime{,-legacy1},intel-graphics-compiler}: drop; opencl-clang: 15.0.1 -> 21.1.0 #440272

Closed

13 tasks

emilazy reviewed Sep 5, 2025

View reviewed changes

RossComputerGuy force-pushed the feat/llvm-bump branch from 542c28d to ddc812d Compare September 14, 2025 22:09

RossComputerGuy added 4 commits September 15, 2025 20:33

doc/rl2511: mention LLVM bump

059414a

rust: track latest LLVM to simplify version bumps

deb4234

llvmPackages_20.libclc: rebase use-default-paths patch

d55bbdc

llvmPackages: llvmPackages_19 -> llvmPackages_21

cabe58b

RossComputerGuy force-pushed the feat/llvm-bump branch from ddc812d to cabe58b Compare September 16, 2025 03:34

emilazy merged commit 6b3366e into NixOS:staging Sep 16, 2025
27 of 31 checks passed

RossComputerGuy deleted the feat/llvm-bump branch September 16, 2025 03:54

LunNova mentioned this pull request Sep 18, 2025

rocmPackages.llvm: use same LLVM version for bootstrap and override #443943

Merged

13 tasks

alexstaeding mentioned this pull request Oct 15, 2025

Build failure: ghc_filesystem #451580

Closed

3 tasks

booxter mentioned this pull request Oct 24, 2025

firefox: 144.0 crashes on page load in nsPNGEncoder::ConvertHostARGBRow when favicons are enabled when official Homebrew builds unaffected on macOS 26 aarch64-darwin #453372

Closed

3 tasks

yzx9 mentioned this pull request Nov 6, 2025

ispc: unbreak on darwin #458797

Merged

13 tasks

collares mentioned this pull request Jan 11, 2026

rPackages.RcppParallel: compile error on 2025.11 (v5.1.10) #479101

Open

3 tasks

Uh oh!

Conversation

RossComputerGuy commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

winterqt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RossComputerGuy commented May 22, 2025

Uh oh!

winterqt commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kilyanni commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

emilazy commented Sep 14, 2025

Uh oh!

emilazy commented Sep 16, 2025

Uh oh!

RossComputerGuy commented Sep 16, 2025

Uh oh!

emilazy commented Sep 16, 2025

Uh oh!

Uh oh!

trofi commented Sep 19, 2025

Uh oh!

trofi commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

RossComputerGuy commented May 16, 2025 •

edited

Loading

winterqt left a comment •

edited

Loading

winterqt commented May 22, 2025 •

edited

Loading

kilyanni commented Aug 25, 2025 •

edited

Loading

trofi commented Oct 6, 2025 •

edited

Loading