Skip to content

python3Packages.cirq: 1.4.1-unstable-2024-09-21 -> 1.5.0#407718

Merged
mweinelt merged 7 commits intoNixOS:masterfrom
sarahec:cirq-bump
May 23, 2025
Merged

python3Packages.cirq: 1.4.1-unstable-2024-09-21 -> 1.5.0#407718
mweinelt merged 7 commits intoNixOS:masterfrom
sarahec:cirq-bump

Conversation

@sarahec
Copy link
Contributor

@sarahec sarahec commented May 16, 2025

Updates python3Packages.cirq to 1.5.0, including:

  • python3Packages.cirq-core
  • python3Packages.cirq-google
  • python3Packages.cirq-aqt
  • python3Packages.cirq-ionq
  • python3Packages.cirq-pasqual
  • python3Packages.cirq-rigetti

Initializes python3Packages.typedunits as it's a dependency of python3Packages.cirq-google

Note: The cirq 1.5.0 release notes declare cirq-regetti as deprecated and removed, but it's still receiving updates in the source.

Part of #407693

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 16, 2025
@sarahec sarahec requested a review from fabaff May 16, 2025 19:54
@nix-owners nix-owners bot requested a review from natsukium May 16, 2025 19:54
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 16, 2025
@nix-owners nix-owners bot requested a review from drewrisinger May 16, 2025 19:59
@sarahec sarahec force-pushed the cirq-bump branch 3 times, most recently from f3e7d5d to b476212 Compare May 16, 2025 20:20
@sarahec sarahec force-pushed the cirq-bump branch 2 times, most recently from 071963d to fdb21d9 Compare May 16, 2025 22:17
@sarahec sarahec marked this pull request as draft May 16, 2025 22:23
@sarahec
Copy link
Contributor Author

sarahec commented May 16, 2025

Now typedunits is having testing issues. Feh.

@sarahec sarahec marked this pull request as ready for review May 16, 2025 22:32
@sarahec sarahec requested a review from dotlambda May 16, 2025 22:40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No response. How would you like to proceed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should use fetchPypi until there are tags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @sarahec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave fetchPypi a try and it's a mess. They don't have a source distro there, just platform- (and python-) specific wheels.

I have two options:

  1. Go back to github, pin on the commit matching the last wheel release date, and give the developer time to respond, or
  2. Write a n-way switch to handle {darwin,linux}x{x86_64,aarch64}x{py312,py313} and a matching shell script to pull all the wheels and calculate their hashes.

Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 sounds good

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Running review

@sarahec sarahec changed the base branch from master to python-updates May 21, 2025 21:47
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 21, 2025
@sarahec sarahec requested a review from mweinelt May 21, 2025 21:50
@sarahec
Copy link
Contributor Author

sarahec commented May 21, 2025

@mweinelt apologies for sending you so many of these. You know what's going on with python-modules

@sarahec sarahec requested a review from dotlambda May 21, 2025 23:12
@sarahec sarahec changed the base branch from python-updates to master May 22, 2025 20:21
@nixpkgs-ci nixpkgs-ci bot closed this May 22, 2025
@github-actions github-actions bot removed 6.topic: teams Relating to team creation, updates, other management actions 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences labels May 22, 2025
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels May 22, 2025
@sarahec sarahec removed 8.has: documentation This PR adds or changes documentation 6.topic: policy discussion Discuss policies to work in and around Nixpkgs labels May 22, 2025
@sarahec
Copy link
Contributor Author

sarahec commented May 22, 2025

Now that I understand the purpose of python-modules, this is back on master due to minimal rebuilds.

@sarahec
Copy link
Contributor Author

sarahec commented May 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407718


x86_64-linux

✅ 36 packages built:
  • python312Packages.cirq
  • python312Packages.cirq-aqt
  • python312Packages.cirq-aqt.dist
  • python312Packages.cirq-core
  • python312Packages.cirq-core.dist
  • python312Packages.cirq-google
  • python312Packages.cirq-google.dist
  • python312Packages.cirq-ionq
  • python312Packages.cirq-ionq.dist
  • python312Packages.cirq-pasqal
  • python312Packages.cirq-pasqal.dist
  • python312Packages.cirq-rigetti
  • python312Packages.cirq-rigetti.dist
  • python312Packages.cirq-web
  • python312Packages.cirq-web.dist
  • python312Packages.cirq.dist
  • python312Packages.stim
  • python312Packages.stim.dist
  • python312Packages.typedunits
  • python312Packages.typedunits.dist
  • python313Packages.cirq-aqt
  • python313Packages.cirq-aqt.dist
  • python313Packages.cirq-core
  • python313Packages.cirq-core.dist
  • python313Packages.cirq-google
  • python313Packages.cirq-google.dist
  • python313Packages.cirq-ionq
  • python313Packages.cirq-ionq.dist
  • python313Packages.cirq-pasqal
  • python313Packages.cirq-pasqal.dist
  • python313Packages.cirq-web
  • python313Packages.cirq-web.dist
  • python313Packages.stim
  • python313Packages.stim.dist
  • python313Packages.typedunits
  • python313Packages.typedunits.dist

@sarahec
Copy link
Contributor Author

sarahec commented May 22, 2025

Last-minute find: load-sensitive tests that needed to be disabled. (Comparing execution time with magic numbers).

@sarahec
Copy link
Contributor Author

sarahec commented May 22, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 407718


aarch64-darwin

✅ 36 packages built:
  • python312Packages.cirq
  • python312Packages.cirq-aqt
  • python312Packages.cirq-aqt.dist
  • python312Packages.cirq-core
  • python312Packages.cirq-core.dist
  • python312Packages.cirq-google
  • python312Packages.cirq-google.dist
  • python312Packages.cirq-ionq
  • python312Packages.cirq-ionq.dist
  • python312Packages.cirq-pasqal
  • python312Packages.cirq-pasqal.dist
  • python312Packages.cirq-rigetti
  • python312Packages.cirq-rigetti.dist
  • python312Packages.cirq-web
  • python312Packages.cirq-web.dist
  • python312Packages.cirq.dist
  • python312Packages.stim
  • python312Packages.stim.dist
  • python312Packages.typedunits
  • python312Packages.typedunits.dist
  • python313Packages.cirq-aqt
  • python313Packages.cirq-aqt.dist
  • python313Packages.cirq-core
  • python313Packages.cirq-core.dist
  • python313Packages.cirq-google
  • python313Packages.cirq-google.dist
  • python313Packages.cirq-ionq
  • python313Packages.cirq-ionq.dist
  • python313Packages.cirq-pasqal
  • python313Packages.cirq-pasqal.dist
  • python313Packages.cirq-web
  • python313Packages.cirq-web.dist
  • python313Packages.stim
  • python313Packages.stim.dist
  • python313Packages.typedunits
  • python313Packages.typedunits.dist

@mweinelt
Copy link
Member

mweinelt commented May 23, 2025

Now that I understand the purpose of python-modules, this is back on master due to minimal rebuilds.

You are confusing python-modules (the directory below which all python libraries are, and python-updates the branch on which we regularly do mass upgrades.

@mweinelt mweinelt merged commit 040d47d into NixOS:master May 23, 2025
18 of 21 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 23, 2025

Successfully created backport PR for release-25.05:

@sarahec
Copy link
Contributor Author

sarahec commented May 23, 2025

Now that I understand the purpose of python-modules, this is back on master due to minimal rebuilds.

You are confusing python-modules (the directory below which all python libraries are, and python-updates the branch on which we regularly do mass upgrades.

I meant one but typed the other on autopilot.

@sarahec sarahec deleted the cirq-bump branch May 23, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants