You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Tested basic functionality of all binary files (usually in ./result/bin/)
I'm getting a test failure with migrant-postgresql-simple:
Running phase: checkPhase
initializing postgresql
The files belonging to this database system will be owned by user "nixbld".
This user must also own the server process.
The database cluster will be initialized with locale "en_US.UTF-8".
The default database encoding has accordingly been set to "UTF8".
The default text search configuration will be set to "english".
Data page checksums are disabled.
creating directory /build/postgresql ... ok
creating subdirectories ... ok
selecting dynamic shared memory implementation ... posix
selecting default "max_connections" ... 100
selecting default "shared_buffers" ... 128MB
selecting default time zone ... UTC
creating configuration files ... ok
running bootstrap script ... ok
performing post-bootstrap initialization ... ok
syncing data to disk ... ok
initdb: warning: enabling "trust" authentication for local connections
initdb: hint: You can change this by editing pg_hba.conf or using the option -A, or --auth-local and --auth-host, the next time you run initdb.
Success. You can now start the database server using:
pg_ctl -D /build/postgresql -l logfile start
starting postgresql
waiting for server to start....2025-05-15 23:20:03.799 UTC [462] LOG: starting PostgreSQL 17.5 on x86_64-pc-linux-gnu, compiled by clang version 19.1.7, 64-bit
2025-05-15 23:20:03.849 UTC [462] LOG: listening on Unix socket "/build/run/postgresql/.s.PGSQL.5432"
2025-05-15 23:20:03.985 UTC [465] LOG: database system was shut down at 2025-05-15 23:19:55 UTC
2025-05-15 23:20:04.044 UTC [462] LOG: database system is ready to accept connections
done
server started
setting up postgresql
CREATE ROLE
CREATE DATABASE
Running 1 test suites...
Test suite migrant-postgresql-simple-test: RUNNING...
2025-05-15 23:20:04.634 UTC [480] ERROR: permission denied to create database
2025-05-15 23:20:04.634 UTC [480] STATEMENT: CREATE DATABASE _migrant_test_3600528;
createdb: error: database creation failed: ERROR: permission denied to create database
Migrant
PostgreSQL
Setup/init: 2025-05-15 23:20:04.639 UTC [482] ERROR: permission denied to create database
2025-05-15 23:20:04.639 UTC [482] STATEMENT: CREATE DATABASE _migrant_test_1488103;
createdb: error: database creation failed: ERROR: permission denied to create database
2025-05-15 23:20:04.643 UTC [484] ERROR: permission denied to create database
2025-05-15 23:20:04.643 UTC [484] STATEMENT: CREATE DATABASE _migrant_test_5773761;
createdb: error: database creation failed: ERROR: permission denied to create database
FAIL
Exception: callProcess: createdb "_migrant_test_3600528" (exit 1): failed
Use -p '/Setup\/init/' to rerun this test only.
Up: FAIL
Exception: callProcess: createdb "_migrant_test_1488103" (exit 1): failed
Use -p '/Up/' to rerun this test only.
Down: FAIL
Exception: callProcess: createdb "_migrant_test_5773761" (exit 1): failed
Use -p '/Down/' to rerun this test only.
3 out of 3 tests failed (0.01s)
Test suite migrant-postgresql-simple-test: FAIL
Test suite logged to:
dist/test/migrant-postgresql-simple-0.1.0.3-migrant-postgresql-simple-test.log
0 of 1 test suites (0 of 1 test cases) passed.
stopping postgresql
waiting for server to shut down....2025-05-15 23:20:04.649 UTC [462] LOG: received fast shutdown request
2025-05-15 23:20:04.690 UTC [462] LOG: aborting any active transactions
2025-05-15 23:20:04.692 UTC [462] LOG: background worker "logical replication launcher" (PID 468) exited with exit code 1
2025-05-15 23:20:04.692 UTC [463] LOG: shutting down
2025-05-15 23:20:04.741 UTC [463] LOG: checkpoint starting: shutdown immediate
.......................2025-05-15 23:20:27.920 UTC [463] LOG: checkpoint complete: wrote 964 buffers (5.9%); 0 WAL file(s) added, 0 removed, 0 recycled; write=0.136 s, sync=22.786 s, total=23.229 s; sync files=308, longest=4.104 s, average=0.074 s; distance=4467 kB, estimate=4467 kB; lsn=0/19AA5E8, redo lsn=0/19AA5E8
2025-05-15 23:20:27.925 UTC [462] LOG: database system is shut down
done
server stopped
I'm getting a test failure with migrant-postgresql-simple
@sternenseemann hmm, right. Looks like postgresqlTestHook provides a single database which it expects the tests to use, whereas migrant-postgresql-simple itself tries to create a new database (with a random name) for each test case in the suite. I don't think it is feasible to patch this on the Nix side here, and for the sake of unbreaking the package I propose dontChecking it. Sounds good?
Looks like postgresqlTestHook provides a single database which it expects the tests to use, whereas migrant-postgresql-simple itself tries to create a new database (with a random name) for each test case in the suite. I don't think it is feasible to patch this on the Nix side here, and for the sake of unbreaking the package I propose dontChecking it. Sounds good?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6.topic: haskellGeneral-purpose, statically typed, purely functional programming language10.rebuild-darwin: 1-10This PR causes between 1 and 10 packages to rebuild on Darwin.10.rebuild-linux: 1-10This PR causes between 1 and 10 packages to rebuild on Linux.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.