Skip to content

haskellPackages.sv2v: fix build and enable#407367

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
Emin017:fix-sv2v
May 16, 2025
Merged

haskellPackages.sv2v: fix build and enable#407367
sternenseemann merged 1 commit intoNixOS:masterfrom
Emin017:fix-sv2v

Conversation

@Emin017
Copy link
Member

@Emin017 Emin017 commented May 15, 2025

  • Jailbreak sv2v package to relax too strict bounds on base <4.19
  • Remove sv2v from broken packages list
  • Remove hydraPlatforms and broken flags to enable building

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 15, 2025
@Emin017 Emin017 changed the title haskellPackages.sv2v: fix build with strict bounds on base haskellPackages.sv2v: fix build and enable May 15, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 15, 2025
@Emin017
Copy link
Member Author

Emin017 commented May 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 407367

Logs: https://github.com/Emin017/nixpkgs-review-gha/actions/runs/15047442438


x86_64-linux

✅ 2 packages built:
  • haskellPackages.sv2v
  • haskellPackages.sv2v.doc

aarch64-linux

✅ 2 packages built:
  • haskellPackages.sv2v
  • haskellPackages.sv2v.doc

x86_64-darwin

✅ 2 packages built:
  • haskellPackages.sv2v
  • haskellPackages.sv2v.doc

aarch64-darwin

✅ 2 packages built:
  • haskellPackages.sv2v
  • haskellPackages.sv2v.doc

* Jailbreak sv2v package to relax too strict bounds on base <4.19
* Remove sv2v from broken packages list
* Remove hydraPlatforms and broken flags to enable building

Signed-off-by: Qiming Chu <[email protected]>
@sternenseemann sternenseemann merged commit bc33919 into NixOS:master May 16, 2025
20 of 21 checks passed
@Emin017 Emin017 deleted the fix-sv2v branch September 8, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants